Skip to content

docs(types): correct misleading comments in Data #3491

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
clippytool wants to merge 1 commit into
base: main
Choose a base branch
from
Open

docs(types): correct misleading comments in Data #3491

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions types/data.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -100,7 +100,7 @@ func (d *Data) Height() uint64 {
return d.Metadata.Height
}

// LastHeader returns last header hash of the block.
// LastHeader returns the previous block's data hash.
func (d *Data) LastHeader() Hash {
return d.LastDataHash
}
Expand All @@ -116,7 +116,7 @@ func (d *Data) Verify(untrustedData *Data) error {
return errors.New("untrusted block cannot be nil")
}
dataHash := d.Hash()
// Check if the data hash of the untrusted block matches the last data hash of the trusted block
// Check if the trusted block's data hash matches the untrusted block's last data hash.
if !bytes.Equal(dataHash[:], untrustedData.LastDataHash[:]) {
return errors.New("data hash of the trusted data does not match with last data hash of the untrusted data")
}
Expand Down
Loading