Skip to content

Add assets, update codex plugin.json - #250

Merged
keertip merged 2 commits into
flutter:mainfrom
keertip:assets
Oct 21, 2026
Merged

keertip merged 2 commits into
flutter:mainfrom
keertip:assets

Conversation

@keertip

@keertip keertip commented Oct 20, 2026

Copy link
Copy Markdown
Collaborator

Add assets - flutter icon and logo. These are needed for publishing the plugins.

Update the Codex plugin.json with the required fields.

@keertip
keertip requested a review from kenzieschmoll October 20, 2026 17:36

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds new SVG assets for the Flutter logo and icon, updates the .codex-plugin/plugin.json manifest with these assets, and adds URLs for privacy policy and terms of service. Feedback on these changes highlights two critical issues: the relative paths to the assets in plugin.json may fail to resolve because the manifest is nested inside .codex-plugin/, and the embedded PNG in assets/flutter-logo.svg contains a truncated base64 string that will cause rendering failures.

Comment thread .codex-plugin/plugin.json Outdated
Comment thread assets/flutter-logo.svg Outdated
@keertip
keertip merged commit 00bc12c into flutter:main Oct 21, 2026
11 checks passed
@keertip
keertip deleted the assets branch October 21, 2026 16:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants