Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion packages/devtools_app/lib/devtools_app.dart
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,6 @@ export 'src/screens/profiler/cpu_profile_model.dart';
export 'src/screens/profiler/profiler_screen.dart';
export 'src/screens/profiler/profiler_screen_controller.dart';
export 'src/screens/profiler/sampling_rate.dart';
export 'src/screens/provider/provider_screen.dart';
export 'src/screens/vm_developer/object_inspector/class_hierarchy_explorer.dart';
export 'src/screens/vm_developer/object_inspector/class_hierarchy_explorer_controller.dart';
export 'src/screens/vm_developer/object_inspector/object_inspector_view_controller.dart';
Expand Down
17 changes: 1 addition & 16 deletions packages/devtools_app/lib/src/app.dart
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,6 @@ import 'screens/performance/performance_controller.dart';
import 'screens/performance/performance_screen.dart';
import 'screens/profiler/profiler_screen.dart';
import 'screens/profiler/profiler_screen_controller.dart';
import 'screens/provider/provider_screen.dart';
import 'screens/vm_developer/vm_developer_tools_controller.dart';
import 'screens/vm_developer/vm_developer_tools_screen.dart';
import 'service/service_extension_widgets.dart';
Expand Down Expand Up @@ -89,20 +88,7 @@ class DevToolsApp extends StatefulWidget {
class DevToolsAppState extends State<DevToolsApp> with AutoDisposeMixin {
List<Screen> get _screens {
if (FeatureFlags.devToolsExtensions.isEnabled) {
// TODO(https://github.com/flutter/devtools/issues/6273): stop special
// casing the package:provider extension.
final containsProviderExtension = extensionService
.currentExtensions
.value
.visibleExtensions
.where((e) => e.name == 'provider')
.isNotEmpty;
final devToolsScreens = containsProviderExtension
? _originalScreens
.where((s) => s.screenId != ScreenMetaData.provider.id)
.toList()
: _originalScreens;
return [...devToolsScreens, ..._extensionScreens];
return [..._originalScreens, ..._extensionScreens];
}
return _originalScreens;
}
Expand Down Expand Up @@ -726,7 +712,6 @@ List<DevToolsScreen> defaultScreens({
AccessibilityScreen(),
createController: (_) => AccessibilityController(),
),
DevToolsScreen<DevToolsScreenController>(ProviderScreen()),
Comment thread
kenzieschmoll marked this conversation as resolved.
DevToolsScreen<AppSizeController>(
AppSizeScreen(),
createController: (_) => AppSizeController(),
Expand Down

This file was deleted.

Original file line number Diff line number Diff line change
Expand Up @@ -104,13 +104,6 @@ enum ScreenMetaData {
icon: Icons.accessibility,
requiresFlutter: true,
),
provider(
'provider',
title: 'Provider',
icon: Icons.attach_file,
requiresLibrary: 'package:provider/',
requiresDebugBuild: true,
),
appSize(
'app-size',
title: 'App Size',
Expand Down Expand Up @@ -155,6 +148,7 @@ enum ScreenMetaData {
this.requiresAdvancedDeveloperMode = false,
this.supportsWebServerDevice = false,
this.worksWithOfflineData = false,
// ignore: unused_element_parameter, this is used in internally.
this.requiresLibrary,
this.tutorialVideoTimestamp,
this.tutorialVideoUrl,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -172,10 +172,6 @@ class SidebarDevToolsScreens extends StatelessWidget {
ScreenMetaData.home ||
ScreenMetaData.debugger ||
ScreenMetaData.vmTools ||
// This screen will be removed from the first party DevTools screens soon.
// If the user depends on package:provider, the provider extension should
// show up in the DevTools extensions list instead.
ScreenMetaData.provider ||
ScreenMetaData.simple => false,
_ => true,
};
Expand Down
3 changes: 2 additions & 1 deletion packages/devtools_app/release_notes/NEXT_RELEASE_NOTES.md
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,8 @@ To learn more about DevTools, check out the

## General updates

TODO: Remove this section if there are not any updates.
* Remove the legacy Provider screen, which was a placeholder to point users to
the `package:provider` DevTools extension. [#10046](https://github.com/flutter/devtools/pull/10046)

## Inspector updates

Expand Down
Loading