Upgrade flutter candidate and DCM version

.github/workflows/build.yaml

@@ -75,7 +75,7 @@ jobs:
           wget -qO- https://dcm.dev/pgp-key.public | sudo gpg --dearmor -o /usr/share/keyrings/dcm.gpg
           echo 'deb [signed-by=/usr/share/keyrings/dcm.gpg arch=amd64] https://dcm.dev/debian stable main' | sudo tee /etc/apt/sources.list.d/dart_stable.list
           sudo apt-get update
-          sudo apt-get install dcm=1.38.3-1 # To avoid errors add `-1` (build number) to the version
+          sudo apt-get install dcm=1.40.0-1 # To avoid errors add `-1` (build number) to the version
           sudo chmod +x /usr/bin/dcm
           echo "$(dcm --version)"
       - name: Setup Dart SDK

flutter-candidate.txt

@@ -1 +1 @@
-fab991537bf1ffb063579a0dd8a47cd4f2874618
+9cba7392c62645f790ccd8c2efda0a6658d260d7

packages/devtools_app/benchmark/web_bundle_size_test.dart

@@ -11,8 +11,8 @@ import 'package:path/path.dart' as path;
 import 'package:test/test.dart';
 
 // Benchmark size in kB.
-const bundleSizeBenchmark = 6000;
-const gzipBundleSizeBenchmark = 1750;
+const bundleSizeBenchmark = 6200;
+const gzipBundleSizeBenchmark = 1900;
 
 void main() {
   group('Web Compile', () {

packages/devtools_app/lib/src/screens/inspector/layout_explorer/flex/flex.dart

@@ -131,7 +131,7 @@ class FlexLayoutExplorerWidgetState
       alignmentEnumEntries = MainAxisAlignment.values;
       selected = propertiesLocal.mainAxisAlignment;
     } else {
-      alignmentEnumEntries = CrossAxisAlignment.values.toList(growable: true);
+      alignmentEnumEntries = CrossAxisAlignment.values.toList();
       if (propertiesLocal.textBaseline == null) {
         // TODO(albertusangga): Look for ways to visualize baseline when it is null
         alignmentEnumEntries.remove(CrossAxisAlignment.baseline);

packages/devtools_app/lib/src/screens/performance/panes/flutter_frames/flutter_frames_chart.dart

@@ -588,7 +588,7 @@ class FlutterFramesChartItem extends StatelessWidget {
                 child: Column(
                   children: [
                     // Dummy child so that the InkWell does not take up the entire column.
-                    const Expanded(child: SizedBox()),
+                    const Spacer(),
                     Row(
                       crossAxisAlignment: CrossAxisAlignment.end,
                       children: [ui, raster],

packages/devtools_app/lib/src/shared/diagnostics/inspector_service.dart

@@ -1270,7 +1270,7 @@ class InspectorObjectGroupManager {
   void _setNextNull() {
     _next = null;
     if (_pendingNext != null) {
-      _pendingNext!.complete(null);
+      _pendingNext!.complete();
       _pendingNext = null;
     }
   }

packages/devtools_app/lib/src/shared/diagnostics/variable_factory.dart

@@ -455,7 +455,7 @@ List<DartObjectNode> createVariablesForBytes(
     variables.add(
       DartObjectNode.fromValue(
         name: '[$name]',
-        value: result[i],
+        value: _formatSimdValue(result[i]) ?? result[i],
         isolateRef: isolateRef,
         artificialName: true,
       ),
@@ -464,6 +464,38 @@ List<DartObjectNode> createVariablesForBytes(
   return variables;
 }
 
+/// The number of decimal places used to display the lanes of a [Float32x4] or
+/// [Float64x2] value.
+const _simdFloatFractionDigits = 6;
+
+/// The number of hex digits used to display a 32-bit lane of an [Int32x4]
+/// value.
+const _simdInt32HexDigits = 8;
+
+/// Returns a display string for [value] if it is a SIMD value ([Int32x4],
+/// [Float32x4], or [Float64x2]), or null otherwise.
+///
+/// We format these values manually instead of relying on `toString()` because
+/// the output of `toString()` for SIMD types is platform dependent (the Dart
+/// VM returns the opaque string 'V128', and the web returns a different format
+/// than the VM historically did). Formatting the lanes ourselves ensures that
+/// users see the actual values on every platform.
+String? _formatSimdValue(Object? value) {
+  String formatFloat(double lane) =>
+      lane.toStringAsFixed(_simdFloatFractionDigits);
+  String formatInt32(int lane) =>
+      lane.toUnsigned(32).toRadixString(16).padLeft(_simdInt32HexDigits, '0');
+
+  return switch (value) {
+    Int32x4(:final x, :final y, :final z, :final w) =>
+      '[${[x, y, z, w].map(formatInt32).join(', ')}]',
+    Float32x4(:final x, :final y, :final z, :final w) =>
+      '[${[x, y, z, w].map(formatFloat).join(', ')}]',
+    Float64x2(:final x, :final y) => '[${[x, y].map(formatFloat).join(', ')}]',
+    _ => null,
+  };
+}
+
 List<DartObjectNode> createVariablesForSets(
   Instance instance,
   IsolateRef? isolateRef,

packages/devtools_app/lib/src/shared/primitives/utils.dart

@@ -288,7 +288,7 @@ class RateLimiter {
       _pendingRequest = Completer();
       await callback();
     } finally {
-      _pendingRequest!.complete(null);
+      _pendingRequest!.complete();
     }
   }
 

packages/devtools_app/lib/src/shared/ui/hover.dart

@@ -583,7 +583,7 @@ class _HoverCardTooltipState extends State<HoverCardTooltip> {
     unawaited(
       hoverCardDataFuture.then(
         (data) => completer.complete(data),
-        onError: (_) => completer.complete(null),
+        onError: (_) => completer.complete(),
       ),
     );
     return completer;

packages/devtools_app/test/screens/debugger/typed_data_variable_test.dart

@@ -372,13 +372,6 @@ void main() {
     expect(
       variable.children.first.displayValue,
       '[ffffffff, 00000000, ffffffff, 00000000]',
-      skip: kIsWeb,
-    );
-    // Formatting is different on the web.
-    expect(
-      variable.children.first.displayValue,
-      '[-1, 0, -1, 0]',
-      skip: !kIsWeb,
     );
   });
 
@@ -408,12 +401,6 @@ void main() {
     expect(
       variable.children.first.displayValue,
       '[0.000000, -232.199997, 2.330000, 9.000000]',
-      skip: kIsWeb,
-    );
-    expect(
-      variable.children.first.displayValue,
-      '[0, -232.1999969482422, 2.3299999237060547, 9]',
-      skip: !kIsWeb,
     );
   });
 
@@ -438,16 +425,7 @@ void main() {
 
     await buildVariablesTree(variable);
 
-    expect(
-      variable.children.first.displayValue,
-      '[0.000000, -1232.222000]',
-      skip: kIsWeb,
-    );
-    expect(
-      variable.children.first.displayValue,
-      '[0, -1232.222]',
-      skip: !kIsWeb,
-    );
+    expect(variable.children.first.displayValue, '[0.000000, -1232.222000]');
   });
 
   test(

packages/devtools_app/test/shared/utils/future_work_tracker_test.dart

@@ -36,12 +36,12 @@ void main() {
         advanceClock(async);
         expect(tracker.active.value, isTrue);
 
-        completer1.complete(null);
+        completer1.complete();
         unawaited(completer1.future);
         advanceClock(async);
         expect(tracker.active.value, isTrue);
 
-        completer2.complete(null);
+        completer2.complete();
         unawaited(completer2.future);
         advanceClock(async);
         expect(tracker.active.value, isFalse);
@@ -66,7 +66,7 @@ void main() {
         advanceClock(async);
         expect(tracker.active.value, isTrue);
 
-        completer2.complete(null);
+        completer2.complete();
         unawaited(completer2.future);
         advanceClock(async);
         expect(tracker.active.value, isFalse);

packages/devtools_app_shared/CHANGELOG.md

@@ -4,6 +4,7 @@ Use of this source code is governed by a BSD-style license that can be
 found in the LICENSE file or at https://developers.google.com/open-source/licenses/bsd.
 -->
 ## 0.5.2-wip
+* Removed redundant argument values.
 * Fix a `RangeError` thrown by `SplitPane` when the number of children
   changes between rebuilds.
 * Fix garbage collection and timeout issues with the result list in `asyncEval` on both native VM and web.

packages/devtools_app_shared/lib/src/service/eval_on_dart_library.dart

@@ -605,19 +605,19 @@ class EvalOnDartLibrary extends DisposableController
     // This is an optimization to avoid sending stale requests across the wire.
     void wrappedRequest() async {
       if (isAlive != null && isAlive.disposed || disposed) {
-        response.complete(null);
+        response.complete();
         return;
       }
       try {
         final value = await request();
         if (!disposed && value is! Sentinel) {
           response.complete(value);
         } else {
-          response.complete(null);
+          response.complete();
         }
       } catch (e) {
         if (disposed || isAlive?.disposed == true) {
-          response.complete(null);
+          response.complete();
         } else {
           response.completeError(e);
         }
@@ -629,7 +629,7 @@ class EvalOnDartLibrary extends DisposableController
       wrappedRequest();
     } else {
       if (isAlive != null && isAlive.disposed || disposed) {
-        response.complete(null);
+        response.complete();
         return response.future;
       }
 

packages/devtools_app_shared/lib/src/service/isolate_state.dart

@@ -47,7 +47,7 @@ class IsolateState {
     _isolateNow = null;
     _isolateLoadCompleter.safeComplete(
       null,
-      () => _isolateLoadCompleter = Completer()..complete(null),
+      () => _isolateLoadCompleter = Completer()..complete(),
     );
     _isPaused.dispose();
   }