Skip to content

Remove prohibited CWE-730 tag from queries - #22862

Open
jketema wants to merge 2 commits into
mainfrom
remove-cwe-730
Open

jketema wants to merge 2 commits into
mainfrom
remove-cwe-730

Conversation

@jketema

@jketema jketema commented Oct 21, 2026 •

Copy link
Copy Markdown
Contributor

Fixes #22318.

MITRE marks CWE-730 as a prohibited category for vulnerability mapping. This removes the external/cwe/cwe-730 tag from all 19 queries (C#, Java, JavaScript, Python, Ruby, Swift) and adds queryMetadata change notes. Other CWE tags are retained; query paths are unchanged.

MITRE marks CWE-730 as PROHIBITED for mapping real-world vulnerabilities.
Remove the external/cwe/cwe-730 tag from all queries and add change notes.
Query paths and suite expectations are unchanged.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

The six change notes need the documented metadata category to select the correct release classification and version-bump behavior.

1 open issue
What changed in this PR

Removes the prohibited CWE-730 vulnerability mapping from CodeQL query metadata across six languages, addressing #22318.

Changes:

  • Removes external/cwe/cwe-730 from 19 queries, including the experimental JavaScript query.
  • Preserves query logic, IDs, paths, and other CWE tags.
  • Adds six language-specific change notes.
File Description
swift/​ql/​src/​queries/​Security/​CWE-730/​RegexInjection.ql Removes CWE-730 from regex-injection metadata.
swift/​ql/​src/​queries/​Security/​CWE-1333/​ReDoS.ql Removes CWE-730 from ReDoS metadata.
swift/​ql/​src/​change-notes/​2026-10-21-remove-cwe-730.md Documents Swift tag removals.
ruby/​ql/​src/​queries/​security/​cwe-1333/​RegExpInjection.ql Removes CWE-730 from regex-injection metadata.
ruby/​ql/​src/​queries/​security/​cwe-1333/​ReDoS.ql Removes CWE-730 from ReDoS metadata.
ruby/​ql/​src/​queries/​security/​cwe-1333/​PolynomialReDoS.ql Removes CWE-730 from polynomial ReDoS metadata.
ruby/​ql/​src/​change-notes/​2026-10-21-remove-cwe-730.md Documents Ruby tag removals.
python/​ql/​src/​Security/​CWE-730/​RegexInjection.ql Removes CWE-730 from regex-injection metadata.
python/​ql/​src/​Security/​CWE-730/​ReDoS.ql Removes CWE-730 from ReDoS metadata.
python/​ql/​src/​Security/​CWE-730/​PolynomialReDoS.ql Removes CWE-730 from polynomial ReDoS metadata.
python/​ql/​src/​change-notes/​2026-10-21-remove-cwe-730.md Documents Python tag removals.
javascript/​ql/​src/​Security/​CWE-834/​LoopBoundInjection.ql Removes CWE-730 from loop-bound injection metadata.
javascript/​ql/​src/​Security/​CWE-730/​ServerCrash.ql Removes CWE-730 from server-crash metadata.
javascript/​ql/​src/​Security/​CWE-730/​RegExpInjection.ql Removes CWE-730 from regex-injection metadata.
javascript/​ql/​src/​Performance/​ReDoS.ql Removes CWE-730 from ReDoS metadata.
javascript/​ql/​src/​Performance/​PolynomialReDoS.ql Removes CWE-730 from polynomial ReDoS metadata.
javascript/​ql/​src/​experimental/​heuristics/​ql/​src/​Security/​CWE-730/​RegExpInjection.ql Removes CWE-730 from experimental query metadata.
javascript/​ql/​src/​change-notes/​2026-10-21-remove-cwe-730.md Documents JavaScript tag removals.
java/​ql/​src/​Security/​CWE/​CWE-730/​RegexInjection.ql Removes CWE-730 from regex-injection metadata.
java/​ql/​src/​Security/​CWE/​CWE-730/​ReDoS.ql Removes CWE-730 from ReDoS metadata.
java/​ql/​src/​Security/​CWE/​CWE-730/​PolynomialReDoS.ql Removes CWE-730 from polynomial ReDoS metadata.
java/​ql/​src/​change-notes/​2026-10-21-remove-cwe-730.md Documents Java tag removals.
csharp/​ql/​src/​Security Features/​CWE-730/​RegexInjection.ql Removes CWE-730 from regex-injection metadata.
csharp/​ql/​src/​Security Features/​CWE-730/​ReDoS.ql Removes CWE-730 from ReDoS metadata.
csharp/​ql/​src/​change-notes/​2026-10-21-remove-cwe-730.md Documents C# tag removals.

Review effort: Max

Comment thread csharp/ql/src/change-notes/2026-10-21-remove-cwe-730.md Outdated
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

The changes are limited to consistent metadata removals and matching change notes, with prior feedback addressed and no unresolved blocking issues.

No open issues 🎉

1 resolved since last review

Review effort: Max

@michaelnebel michaelnebel left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

CodeQL maps CWE-730, which MITRE prohibits from being used for mapping

4 participants