Repository navigation
Conversation
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Barrier guards now block individual inputs to SSA phi nodes. This prevents false positives for patterns where an unsafe value is replaced with a safe default on the guard’s failing branch.
The shared SSA library represents phi inputs as synthetic data-flow nodes, allowing a guard to block one input without blocking the entire phi node. Languages that use shared SSA for ordinary SSA flow benefit from this directly.
JavaScript currently uses shared SSA only for use-use flow, while its legacy SSA implementation remains responsible for ordinary definition-to-use flow. That legacy graph had a direct
definition -> phiedge which bypassed the guarded synthetic node in the shared graph.This change adds equivalent phi-input nodes to the legacy JavaScript graph and routes flow as:
Barrier guards can then block the relevant input while preserving flow from other inputs.
This also fixes an existing false positive in a test for
js/command-line-injection.