Repository navigation
Conversation
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: d460b2a4-7884-479b-842d-ccffc549a94d
Preserve upstream's Windows launch fallback documentation alongside the explicit job-breakaway guarantee. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: d460b2a4-7884-479b-842d-ccffc549a94d
Contributor
There was a problem hiding this comment.
🔵 Needs a closer look
The new breakaway policy lacks checked-in regression coverage, leaving nested-job cleanup behavior unverified.
1 open finding
What changed in this PR
Updates the Rust SDK’s Windows Job policy to allow explicit descendant breakaway.
Changes:
- Enable explicit breakaway while preserving kill-on-close and ordinary descendant ownership.
- Document that escaped descendants can survive SDK cleanup.
| File | Description |
|---|---|
rust/src/process_tree.rs |
Adds JOB_OBJECT_LIMIT_BREAKAWAY_OK to the Job policy. |
rust/README.md |
Clarifies escaped-descendant lifetime. |
🧠 Review effort: Max
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: d460b2a4-7884-479b-842d-ccffc549a94d
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
CREATE_BREAKAWAY_FROM_JOB.JOB_OBJECT_LIMIT_KILL_ON_JOB_CLOSEand ordinary descendant ownership; do not enable silent breakaway or change suspended launch/assignment.This is limited to the Rust SDK job policy. CLI/runtime launch changes and process-group cleanup in the other SDKs are separate work. Restrictive enclosing jobs remain authoritative, and Node's
detached: trueis not equivalent to explicit Win32 job breakaway.Validation
git diff --checkpassed.