Repository navigation
feat(app): reorganize settings into grouped pages with shared row components - #484
Merged
Merged
Conversation
…ponents Settings now groups pages under the app (General, Providers, Team, Beta) and This Mac (Ace Helper, Computer use, Updates). This Mac is split: team connectivity moves to Team, and helper, CLI, and tools stay together. Rows use shared Row, TextRow, Segmented, Value, and Confirm components with at most one short description line. Page descriptions, disclosures, and long explainers are gone. Why: apps/app/src/settings-layout.tsx#function Row | rows keep at most one short description line; longer guidance belongs in docs, not settings
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Settings cleanup:
settings-layout.tsx:PageandGroup: a section title, plus an optional action on the right.Row: a label, at most one description line, and the control on the right.TextRow: a text setting. Save appears only when the value has changed, and Escape discards the edit.Segmented(used for theme),Select,Value(read-only status), andConfirm(an inline destructive confirmation; it replaces four copies of the same markup).Verification
bun typesandbun run cipass.bun desktop devbuild.Built in Ace
Written with Claude Code outside Ace while dogfooding. I checked the layout with desktop tools against a dev build. Nothing Ace lacks blocked this work.