Repository navigation
chore(ci): preserve gem lockfile resolution under toys 0.22.0 and Bundler 4 - #36638
Merged
Merged
Conversation
torreypayne
changed the title
torreypayne
added this pull request to stack #36645
October 17, 2026 00:38
torreypayne
marked this pull request as ready for review
October 19, 2026 18:46
quartzmo
approved these changes
Oct 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Preserves per-gem
Gemfile.lockresolution duringtoys testundertoys 0.22.0and Bundler 4.0+:jsonfromGem.loaded_specsinToys::Utils::Gems#create_modified_gemfilesoload_git(Toys::Utils::GitCache) does not override the gem's lockedjsonversion (e.g.2.21.2) with a newerjson(3.1.0) installed inGEM_HOME.Toys::Utils::Gems#delete_modified_gemfiletoat_exitsoENV["BUNDLE_LOCKFILE"](set by Bundler 4.0+) still exists when childrubytest processes run.