Repository navigation
Conversation
Requiring the gem with warnings enabled redefines BigtableSource::Column because column_family.rb contains a copy of the class already required from column.rb. Remove the duplicate definition to eliminate the warnings. closes: googleapis#36647
torreypayne
approved these changes
Oct 21, 2026
quartzmo
approved these changes
Oct 21, 2026
quartzmo
added
api: bigquery
yoshi-kokoro
removed
the
kokoro:force-run
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requiring
google-cloud-bigquerywith warnings enabled emits 28 diagnostic lines becauseBigtableSource::Columnis defined in bothcolumn.rbandcolumn_family.rb.Remove the duplicate class and documentation from
column_family.rb, retaining its existing require ofcolumn.rb.Validation (Ruby 4.0.7, Linux aarch64):
bundle exec rake test: 1,433 runs, 10,788 assertions, no failures or errors.bundle exec rake cireaches doctests but does not pass: 459 errors and 11 skips also occur on the unmodified baseline. Comparing test names and error messages (normalizing generated object IDs and UUIDs) found no new error cases. Unit tests were also run separately because the CI task stops at doctests.Closes: #36647