Repository navigation
fix: align app icon to top in compact message layout - #459
Open
feather2222 wants to merge 1 commit into
Open
feather2222 wants to merge 1 commit into
feather2222 wants to merge 1 commit into
Conversation
In compact mode the application icon was constrained to both the top and bottom of the list item, vertically centering it. With long messages the icon scrolled out of view. Constrain it to the top only, matching the normal layout behavior. Fixes gotify#456
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #456
Problem
In compact mode (
Settings => Message layout => Compact), the applicationicon is constrained to both the top and the bottom of the list item, which
vertically centers it. For long messages, the icon is scrolled out of view
and only becomes visible after scrolling to the vertical middle of the
message.
Change
Removed the
app:layout_constraintBottom_toBottomOf="parent"constraintfrom
message_imageinmessage_item_compact.xml, so the icon staysaligned to the top of the item — matching the behavior requested in the
issue for both layouts.
Testing
./gradlew :app:assembleDebug :app:lintDebug(both pass)list item instead of vertically centered