Repository navigation
fix(notifier): ignore queued messages after stopping - #2110
Open
timothyanderson096-ocdealcheck wants to merge 1 commit into
Open
timothyanderson096-ocdealcheck wants to merge 1 commit into
timothyanderson096-ocdealcheck wants to merge 1 commit into
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1712.
With an asyncio loop configured, a Notifier can queue a message delivery before stop() closes its listeners. That queued delivery can later call a log writer and raise "I/O operation on closed file".
Check the stopped state before each listener callback. This prevents queued deliveries from reaching stopped listeners and stops delivery to remaining listeners when a callback calls stop(). Already-scheduled coroutine tasks and callbacks currently executing on another thread remain outside this fix.
The regression uses a real CanutilsLogWriter backed by StringIO and checks both the closed stream and the event loop's error handler. Additional coverage checks delivery before shutdown, reentrant stop and active-listener error reporting. Both shutdown regressions fail on unmodified main and pass with the guard.
Validation on Linux, based on main b4f82ab:
The full suite was not repeated: a same-base run earlier in this environment had 28 IPv4/IPv6 multicast failures due to unavailable network routes. No physical CAN hardware was used. The async exception-routing work in #2096 addresses a separate path. Prepared with AI assistance and independently reviewed.
Timothy Anderson — Spotted Ridge Engineering / OC Labs
GDN — Global Decision Network
timothyanderson096@gmail.com · Engineering evidence