Repository navigation
chore(ci): pin the workflow token to read-only contents - #83
Merged
Merged
Conversation
CodeQL flagged all four CI jobs with missing-workflow-permissions: without a permissions block they take whatever token scope the repository default grants. The default is read today, but that is a setting outside the repo; declaring contents: read in the workflow keeps the token read-only even if the default is changed later. Co-Authored-By: htjulia <htjulia1@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The first CodeQL run (default setup, enabled 2026-10-13) raised four
actions/missing-workflow-permissionsalerts (#1–#4, medium), one per job inci.yml:lint,build,testandci-complete. With nopermissions:block, every job gets the token scope set by the repository default.That default is
readtoday (default_workflow_permissions: read), so the token is not over-scoped right now. But the setting lives outside the repo. If someone switches it to read/write, every CI run, including thenpm ciof third-party packages, would start holding a write token, and nothing in review would show it.What
permissions: contents: readto.github/workflows/ci.yml. All four jobs only check out the code, run npm and compare job results, so read access to contents is all they use.ci-complete.Verification
lint,build,testandci-completemust pass with the narrowed token. That shows nothing needed more thancontents: read.mainafter merge.