Repository navigation
chore(deps): resolve dev-only advisories through the lockfile - #84
Merged
Merged
Conversation
Dependabot alerts, enabled today, opened twenty advisories. All of them sit in development-only transitive packages, nearly all under the shadcn CLI. npm audit fix --package-lock-only moves nine of those packages to patched versions inside the ranges their parents already allow, so package.json is unchanged and no override is needed. One advisory remains: braces (GHSA-vfj7-8cjw-p6xm) has no patched release, and npm's only suggested fix is a downgrade to shadcn 1.0.0. Co-Authored-By: htjulia <htjulia1@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Dependabot alerts, enabled 2026-10-13, opened 20 advisories (10 more were auto-dismissed). All of them are in development-only transitive packages. Nearly all come in through the
shadcnCLI (via@modelcontextprotocol/sdk,ts-morphand others), which is used to pull components and never reaches the bundle.npm audit --omit=devwas already clean.They still show as open critical/high alerts in the Security tab. Every one that has a patched release can be fixed inside the version ranges the parent packages already accept.
What
npm audit fix --package-lock-only. Only the lockfile changes:package.jsonis unchanged, with nooverridesand no direct dependency bumps. This is the same approach as #30.@modelcontextprotocol/sdkhonoproxy-addrfast-uriip-addressbrace-expansionpostcss-selector-parserqsundici(shadcn's copy)jsdom's ownundici(8.11.2) is not touched.What remains
One advisory:
bracesGHSA-vfj7-8cjw-p6xm, reached throughshadcn → fast-glob → micromatch → braces. It has no patched version, and npm's only suggested fix isshadcn@1.0.0, a downgrade across three majors. Dependabot has already auto-dismissed it as a low-impact dev alert.npm auditgoes from 16 findings (1 critical, 11 high, 4 moderate) to 7 high, and all 7 are this one advisory propagating up the chain.Verification
npm ci,npm run lint(warnings only, same set asmain),npm run build.dist/assetsfile names, which are content hashes, are identical tomain.npx shadcn --versionstill runs (4.21.4).npm test: 245 tests.trace-windowscenario tests (holds one page…,drops evicted rows from a search result too,grows only by what the user loads) fail now and then under the full suite. This is not caused by this PR: the same tests failed 2 of 12 full runs onmainand 3 of 12 on this branch, and each passes 5/5 in isolation. None of the changed packages are on the test path. This is tracked separately.