Repository navigation
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
src/proto/h1/io.rscarries a keep-in-sync note aboveDEFAULT_MAX_BUFFER_SIZE:There is no
server::conn::Httptype anymore. Theserver::connmodule exposes onlyhttp1andhttp2, and the doc that actually states this default (/// Default is ~400kb.) isBuilder::max_buf_sizeinsrc/server/conn/http1.rs. The 1.x refactor renamed the type but left this pointer behind, so it now directs maintainers to a path that does not exist.I only updated the path in the note; the constant and its value are unchanged.
Why it matters
The stale pointer makes the "update this doc when you change the default" instruction unactionable — following it leads nowhere. Pointing at
server::conn::http1::Builder::max_buf_sizerestores the intended link.Test plan
Comment-only change; no code paths touched. Verified at the current
masterthatsrc/server/conn/mod.rsdeclares onlypub mod http1;/pub mod http2;, and thatBuilder::max_buf_sizewith the~400kbdefault lives insrc/server/conn/http1.rs.