Skip to content

Correct the live view media reason row and timeout warning #698

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
robertjamesprior wants to merge 2 commits into
base: main
Choose a base branch
from
+2 −2
Open

Correct the live view media reason row and timeout warning #698

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7caccad
Correct the media reason row to cover through connected
robertjamesprior Oct 13, 2026
df0367d
Cover `completed` in the media reason row and scope the timeout warning
robertjamesprior Oct 14, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions browsers/live-view.mdx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -109,7 +109,7 @@ Both terminal events carry the same `reason`, so branch on it instead of matchin
| --- | --- |
| `transport` | the socket never opened inside its bound, or closed before signaling |
| `signaling` | the socket opened but no offer arrived inside its bound |
| `media` | a peer exists but ICE never reached `checking` inside its bound |
| `media` | a peer exists but ICE never reached `connected` or `completed` inside its bound — this covers a peer that stalls after `checking` |
| `peer` | peer construction or the remote offer threw |
| `unsupported` | the browser has no `RTCPeerConnection` |
| `server` | the server closed the connect |
Expand Down Expand Up @@ -161,7 +161,7 @@ window.addEventListener('message', (event) => {
arm();
```

Do not gate on `KERNEL_CONNECTION_TIMEOUT` alone. The watchdog behind it is cleared once negotiation begins, so a connection that stalls after that point never emits it. Log it alongside `KERNEL_PLAYING` to capture the connection state at the moment things stalled.
Do not gate on `KERNEL_CONNECTION_TIMEOUT` alone. On images without the connect-failure fix, the watchdog behind it is cleared once negotiation begins, so a connection that stalls after that point never emits it. Log it alongside `KERNEL_PLAYING` to capture the connection state at the moment things stalled.

`KERNEL_CONNECTION_FAILED` and `KERNEL_CONNECTION_TIMEOUT` are both terminal, and a failed connect posts one of them, never both. Whichever arrives, nothing further happens until the iframe reloads. Surface a persistent message rather than remounting blindly: a `peer` or `unsupported` reason is a property of the browser environment, so a remount repeats it, while a `transport` reason is worth one retry.

Expand Down
Loading