[mattiaswal]

A zone id like %sw2p2 is not a valid escape, so requests gives up on
its normal quoting and re-quotes every % in the URL, turning a key's
%2F into %252F. The workaround only restored the host, and rousette
aborts on the mangled key. QEMU never sees it since its zone names,
d4a say, happen to parse as escapes.

Description

Checklist

Tick relevant boxes, this PR is-a or has-a:

• Bugfix
  • Regression tests
  • ChangeLog updates (for next release)
• Feature
  • YANG model change => revision updated?
  • Regression tests added?
  • ChangeLog updates (for next release)
  • Documentation added?
• Test changes
  • Checked in changed Readme.adoc (make test-spec)
  • Added new test to group Readme.adoc and yaml file
• Code style update (formatting, renaming)
• Refactoring (please detail in commit messages)
• Build related changes
• Documentation content changes
  • ChangeLog updated (for major changes)
• Other (please describe):

[troglobit]

Two small notes, neither blocking:

1. The URL is now sent exactly as built. Anything outside a list key that still needs encoding, such as a space in some hand-written path, used to be quoted by requests. Now http.client will reject it. I didn't find any test that does this, and list keys are fully encoded.
2. The 502s mean rousette aborted on the malformed key (02%3A00… after decoding once) instead of answering 400. That's a robustness bug in rousette worth reporting upstream. The abort probably also explains the "broken RESTCONF frontend" in the tests that followed.

[mattiaswal]

Two small notes, neither blocking:

1. The URL is now sent exactly as built. Anything outside a list key that still needs encoding, such as a space in some hand-written path, used to be quoted by requests. Now http.client will reject it. I didn't find any test that does this, and list keys are fully encoded.
2. The 502s mean rousette aborted on the malformed key (02%3A00… after decoding once) instead of answering 400. That's a robustness bug in rousette worth reporting upstream. The abort probably also explains the "broken RESTCONF frontend" in the tests that followed.

I know, but the problem is we are not using long from the latest version of rousette, not think it is worth it.

[troglobit]

Failure in new FDB test on Alder and Styx expected, separate fix for that incoming in PR #1723.