Repository navigation
Conversation
The Go AI SDK needs Go 1.26 and go-server-sdk v7.19.1. This change moves the module to Go 1.26 and go-server-sdk from v7.13.4 to v7.19.1. golangci-lint v1.63.4 cannot read the type data of Go 1.26, so the pre-commit hook moves to v2.11.4. The new .golangci.yml keeps the v1 rules: staticcheck runs only the SA and S1 checks, and unchecked Close and print calls are not errors. The hook now pins Go 1.26.0. Without the pin, pre-commit downloads the newest Go, and the linter cannot read the type data of a newer release. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This was referenced Oct 19, 2026
atornsii
added this pull request to stack #902
October 20, 2026 15:48
atornsii
marked this pull request as ready for review
October 20, 2026 17:30
atornsii
requested review from
a team,
btesfamariam and
tiffanylphan
and removed request for
a team,
btesfamariam and
tiffanylphan
October 20, 2026 17:30
Keep the dependency updates from main. Keep go 1.26 and go-server-sdk v7.19.1 from this branch. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
🔍 Devin Review: 1 flag
Not posted on this PR by your GitHub settings — view it in Devin Review. (Configure)
# Conflicts: # .golangci.yml # .pre-commit-config.yaml # AGENTS.md
btesfamariam
approved these changes
Oct 21, 2026
atornsii
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This draft moves the module to Go 1.26 and updates go-server-sdk. The Go AI SDK (
github.com/launchdarkly/go-ai-sdk) needs ago 1.26directive and go-server-sdk v7.19.1, so this PR must merge before the agent PRs (#894 to #930).mainhas changed since this PR opened. It now has golangci-lint v2, a.golangci.ymlthat keeps the v1 rules, andtoolchain go1.26.10(#933). This PR mergesmainand keeps all of that.What changed
go.mod: thegodirective goes from1.25.0to1.26. Thetoolchain go1.26.10line frommainstays. Both CI workflows read the version fromgo.mod..pre-commit-config.yaml: golangci-lint goes from v2.9.0 to v2.11.4, and the hook setslanguage_version: 1.26.0.AGENTS.md: the linter version, and a pointer to.golangci.yml.Why the hook pins Go
Without
language_version, pre-commit downloads the newest Go to build the linter. A linter that is built with a Go release newer than itself cannot read that release's type data, and it fails on every package. The pin makes pre-commit build the linter with Go 1.26, the version ingo.mod.Testing
go build ./...,go vet ./..., andgo test ./...pass on Go 1.26.pre-commit run --all-filespasses afterpre-commit clean.main, the stack up to feat(setup): send the agent's model calls to a LaunchDarkly Bedrock relay (7/7) #930 merges intomainwithout conflicts.🤖 Generated with Claude Code
Note
Overview
This PR bumps the module to Go 1.26 (
go 1.25.0→go 1.26) and refreshes LaunchDarkly server SDK dependencies to v7.19.1 (with go-server-sdk-evaluation v3.2.0), aligning with upcoming Go 1.26 / AI SDK work.Pre-commit golangci-lint moves from v2.9.0 to v2.11.4 and pins
language_version: 1.26.0on the hook so the linter is built with the same Go asgo.mod, avoiding type-data mismatches when pre-commit would otherwise pull a newer Go.AGENTS.md documents the new linter version and points readers at
.golangci.ymlfor Go lint configuration.Reviewed by Cursor Bugbot for commit 68f210f. Bugbot is set up for automated code reviews on this repo. Configure here.