Repository navigation
Add workspace shortcuts and say why taskbar icons are not combined - #87
Merged
Merged
Conversation
…nd, as an admin WindowTabs
…raised, so the tabs do not flash
…not only every tenth of a second
…order changes put it back
…ing for order changes instead of polling
…art, and where the reason shows
|
Sorry, BUt I'm not sure how to get the new build. I only see the old one
on the site.
Can you let me know how?
…On Thu, Oct 22, 2026 at 11:55 PM leaf ***@***.***> wrote:
Workspace shortcuts (Fixes #82
<#82>)
- Two new shortcuts under *Settings → Shortcuts*, in a *Workspaces*
card, unset by default:
- *Save workspace* saves the windows as a new workspace, as *Save
layout* does.
- *Restore workspace* restores the workspace last saved or restored
(from a shortcut or from Settings), or the newest one if that one was
deleted or renamed.
- The Shortcuts page now lists every shortcut from the settings
catalog, so a new one can no longer be left off the page.
- An open Workspaces page picks up a workspace saved by shortcut, so
its next save keeps it.
Notices
The notice used by these shortcuts and by the session restore at sign-in
is now a card like an IDE's notifications:
- At the bottom right of the screen, where Windows shows its own
notifications; it slides in and out.
- Fixed size, with the app's icon, a bold title (the workspace's name,
or "Last session") and the message below it in up to two lines.
- While pointed at, it shows a close button and does not go.
- How long it stays depends on what it says: 4 s when done, 8 s when
some windows were not found, until closed for an error (with a warning
icon).
- A failed restore or save now shows an error notice; before, the
notice just went away.
Why taskbar icons are not combined (#84
<#84>)
A group set to combine its taskbar icons can keep a button per window:
when WindowTabs and a window run with different rights, when Windows has
not said which virtual desktop the windows are on, or when it would not
move the group's button there. Until now nothing said which.
- The group's tab menu shows the reason, inset and dimmed, under *Combine
taskbar icons*.
- *Settings → Diagnostics* lists each group of several windows with
its taskbar state.
This does not change when icons combine; it shows which case applies.
@jaherb00 <https://github.com/jaherb00>, could you try this build and
tell us what the tab menu, or the taskbarGroups part of the diagnostics
report, shows for the group of Explorer windows? Whether WindowTabs runs as
administrator would also help.
Tabs when WindowTabs runs as administrator
A strip can only be owned by a window whose input it may share, so with
WindowTabs elevated and normal apps, strips are owned by nothing and
Windows does not raise them with their window. Tabs were left under other
windows, and went under their own window when it was maximized or its title
bar clicked.
- The strip goes back over its window when the window is activated,
raised from a tab, maximized or restored.
- Any other raise, such as a browser raising itself again a moment
after activation or a title bar click, is caught by listening for changes
in the order of top-level windows.
- README now says that an admin WindowTabs keeps normal windows'
taskbar buttons apart.
No polling guards
The split view guard checked the window order every 200 ms for as long as
a split was shown. It now runs once per burst of order changes, and the
admin strip guard uses the same event. The event is only listened for while
a split is shown or a strip is owned by nothing.
Smaller changes
- The session restore setting's description fits on one line, with
shorter choices beside it.
Tests
Regression checks added to GroupLifecycle, SettingsEditors, SettingsTheme
and PopupRendering: the reported taskbar state, the last used workspace,
shortcut saves reaching an open page, every shortcut having an editor, the
notice's place, size, kinds and close button, and an unowned strip coming
back over its window after activation, a raise and a tab click.
------------------------------
You can view, comment on, or merge this pull request online at:
#87
Commit Summary
- f7906d3
<f7906d3>
Say why a group's taskbar icons are not combined
- 2c17bda
<2c17bda>
Add shortcuts to save a workspace and restore the last one
- a08ec22
<a08ec22>
Show the workspace shortcuts on the Shortcuts page
- 333fbd7
<333fbd7>
Keep the session restore description to one line
- df93688
<df93688>
List only groups of several windows in the diagnostics report's taskbar
section
- 7a14001
<7a14001>
Slide notices in and out at the bottom right of the screen
- 8e2f06c
<8e2f06c>
Quote the workspace's name in its notices, with no count after a colon
- 729e5e1
<729e5e1>
Show notices as a card of fixed size with a bold title above the message
- ad16680
<ad16680>
Keep notices up while pointed at, with a close button, and errors until
closed
- becc420
<becc420>
Inset the reason under Combine taskbar icons so it does not read as a
command
- e555b6f
<e555b6f>
Bring a window's tabs up with it when WindowTabs runs with other rights
- 73452be
<73452be>
Keep a window's tabs over it when it rises with no change of foreground, as
an admin WindowTabs
- 699a2c4
<699a2c4>
Put an admin WindowTabs' strip back over its window as the window is
raised, so the tabs do not flash
- 9a7346f
<9a7346f>
Put an admin WindowTabs' strip back at every change of window order, not
only every tenth of a second
- 3c6fd20
<3c6fd20>
Look at an admin WindowTabs' strip every fifth of a second, now that order
changes put it back
- a3e6dfb
<a3e6dfb>
Keep tabs over split panes and an admin WindowTabs' windows by listening
for order changes instead of polling
- d583c82
<d583c82>
Say that an admin WindowTabs keeps normal windows' taskbar buttons apart,
and where the reason shows
File Changes
(22 files <https://github.com/leafOfTree/WindowTabs/pull/87/files>)
- *M* README.md
<https://github.com/leafOfTree/WindowTabs/pull/87/files#diff-b335630551682c19a781afebcf4d07bf978fb1f8ac04c6bf87428ed5106870f5>
(8)
- *M* WtProgram/GroupPlugins/SuperBarPlugin.fs
<https://github.com/leafOfTree/WindowTabs/pull/87/files#diff-4054693c7b4bc861405260651f76005ea7d83661b9332e97e25c2ca23b2a8a3f>
(15)
- *M* WtProgram/ManagerViewService/Views/DiagnosticsView.fs
<https://github.com/leafOfTree/WindowTabs/pull/87/files#diff-6fec62e829ed0d2739fa8ab0edf0b3d151709ae8c2fcba75f118387a5d8da35c>
(14)
- *M* WtProgram/ManagerViewService/Views/HotKeyView.fs
<https://github.com/leafOfTree/WindowTabs/pull/87/files#diff-17763af6e20a7bd5624fc2dd9f009d193cbc472eb317d5dc86830aabc51864ee>
(13)
- *M* WtProgram/ManagerViewService/Views/WorkspaceView.fs
<https://github.com/leafOfTree/WindowTabs/pull/87/files#diff-1115cd847a09a13508f5ccb655613af1dd42d7d7113293609f6319c548d8b310>
(6)
- *M* WtProgram/Notice.fs
<https://github.com/leafOfTree/WindowTabs/pull/87/files#diff-4b5201e214ce0d50d069f2e1839b93336f562a9ed83865bc308a15b03db5dea7>
(222)
- *M* WtProgram/Program.fs
<https://github.com/leafOfTree/WindowTabs/pull/87/files#diff-f6dd5727f0427719460d537f66e23515fafb4b7e196d8dec18f449fedaeeb959>
(56)
- *M* WtProgram/Shared/ProgramTypes.fs
<https://github.com/leafOfTree/WindowTabs/pull/87/files#diff-6685e40c50e0ce2aa5d6b3fe148390b4535192e49a9fcb33a92fbb1f1a9f7b67>
(21)
- *M* WtProgram/Shared/SettingsCatalog.fs
<https://github.com/leafOfTree/WindowTabs/pull/87/files#diff-9f472b99b19e74f0bbc738be6d7e23e32b32c6dc1f7d6a39d15d3d819d06719c>
(3)
- *M* WtProgram/Shared/Strings.fs
<https://github.com/leafOfTree/WindowTabs/pull/87/files#diff-cd9ce9a705cde9f2cb3c519ce5dab9e3054c9a438f59a37efb8f6fe1d5cee9c4>
(74)
- *M* WtProgram/Shared/ThemedMenu.fs
<https://github.com/leafOfTree/WindowTabs/pull/87/files#diff-2ee0c9f815097d97196183bd46c4c6117c077adbba77d3a3ec6caee63b7e5931>
(15)
- *M* WtProgram/Shared/Win32.fs
<https://github.com/leafOfTree/WindowTabs/pull/87/files#diff-282b16fa56f9db4d318f96ca13e8ae6b6cdfd3f5d8ccf5b014254b1650373c01>
(13)
- *M* WtProgram/Shared/Win32Menu.fs
<https://github.com/leafOfTree/WindowTabs/pull/87/files#diff-7253ab5b778f7997b7ff829df916f7852e7094d578d97b586b61e94a9ddb1bf9>
(4)
- *M* WtProgram/TabStripDecorator.fs
<https://github.com/leafOfTree/WindowTabs/pull/87/files#diff-c284d81838036c180c630397b69258052a4d5756c42c4efa3cd35e2991047814>
(14)
- *M* WtProgram/WindowGroup.fs
<https://github.com/leafOfTree/WindowTabs/pull/87/files#diff-0b0c038023bf903a83404a0a34c6df65e0eed7b99b52c573f4b95e05e378b94a>
(90)
- *M* WtProgram/Workspace/WorkspaceModel.fs
<https://github.com/leafOfTree/WindowTabs/pull/87/files#diff-f854769f02f46ec1bebf51d6cf294513fdbba2507db4bce3802585c91aeed90c>
(42)
- *M* docs/input-isolation-probe.md
<https://github.com/leafOfTree/WindowTabs/pull/87/files#diff-e4b525015f93ef0a36fe126dee85be7580bdcbc360b4886ff777afdf4930436e>
(12)
- *M* docs/split-view-design.md
<https://github.com/leafOfTree/WindowTabs/pull/87/files#diff-86b4246c74d90ae10b65af5804aa0d3f36d9f8c6b8d8b52d28042ff8cbfb3f83>
(2)
- *M* tests/GroupLifecycle.fsx
<https://github.com/leafOfTree/WindowTabs/pull/87/files#diff-6b38da40081064b8849889197b7b48a4cc6c806d3480fcc412a79cd18e8eb1db>
(68)
- *M* tests/PopupRendering.fsx
<https://github.com/leafOfTree/WindowTabs/pull/87/files#diff-9834795b1cc064c3da882fc56c8db51c93f1c08299a9016c1e691ef1c946ab1e>
(46)
- *M* tests/SettingsEditors.fsx
<https://github.com/leafOfTree/WindowTabs/pull/87/files#diff-eaa30655857b9ff5a6807ab788a78c8f82153de6393168ea9c359c0fccbe5532>
(7)
- *M* tests/SettingsTheme.fsx
<https://github.com/leafOfTree/WindowTabs/pull/87/files#diff-51d7005893d3f3759e2195b65710ae6ae03a0e18f5e596d1b9a62298ae77c9fa>
(15)
Patch Links:
- https://github.com/leafOfTree/WindowTabs/pull/87.patch
- https://github.com/leafOfTree/WindowTabs/pull/87.diff
—
Reply to this email directly, view it on GitHub
<#87?email_source=notifications&email_token=BAZVAR7SG3VTURLUREYBLMT5VLJEFA5CNFSNUABEM5UWIORPF5TWS5BNNB2WEL2QOVWGYUTFOF2WK43UF42DSNZXGU3DGNZZG2THEZLBONXW5J3NMVXHI2LPN2SWK5TFNZ2KYZTPN52GK4S7MNWGSY3L>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/BAZVAR2TF77FELNEGOGKBAL5VLJEFAVCNFSNUABFKJSXA33TNF2G64TZHMYTSNJSGE4TQNZTHNEXG43VMU5TKOJZGE2TQMRXGI3KC5QC>
.
Triage notifications, keep track of coding agent tasks and review pull
requests on the go with GitHub Mobile for iOS
<https://github.com/notifications/mobile/ios/BAZVAR5BIPXKUV7B2UYIRRL5VLJEFA5CNFSNUABEM5UWIORPF5TWS5BNNB2WEL2QOVWGYUTFOF2WK43UF42DSNZXGU3DGNZZG2THEZLBONXW5J3NMVXHI2LPN2SWK5TFNZ2KUZTPN52GK4S7NFXXG>
and Android
<https://github.com/notifications/mobile/android/BAZVARYPZ5EZ6PHWER7FDWT5VLJEFA5CNFSNUABEM5UWIORPF5TWS5BNNB2WEL2QOVWGYUTFOF2WK43UF42DSNZXGU3DGNZZG2THEZLBONXW5J3NMVXHI2LPN2SWK5TFNZ2K4ZTPN52GK4S7MFXGI4TPNFSA>.
Download it today!
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Workspace shortcuts (Fixes #82)
Notices
The notice used by these shortcuts and by the session restore at sign-in is now a card like an IDE's notifications:
Why taskbar icons are not combined (#84)
A group set to combine its taskbar icons can keep a button per window: when WindowTabs and a window run with different rights, when Windows has not said which virtual desktop the windows are on, or when it would not move the group's button there. Until now nothing said which.
This does not change when icons combine; it shows which case applies. @jaherb00, could you try this build and tell us what the tab menu, or the
taskbarGroupspart of the diagnostics report, shows for the group of Explorer windows? Whether WindowTabs runs as administrator would also help.Tabs when WindowTabs runs as administrator
A strip can only be owned by a window whose input it may share, so with WindowTabs elevated and normal apps, strips are owned by nothing and Windows does not raise them with their window. Tabs were left under other windows, and went under their own window when it was maximized or its title bar clicked.
No polling guards
The split view guard checked the window order every 200 ms for as long as a split was shown. It now runs once per burst of order changes, and the admin strip guard uses the same event. The event is only listened for while a split is shown or a strip is owned by nothing.
Smaller changes
Tests
Regression checks added to GroupLifecycle, SettingsEditors, SettingsTheme and PopupRendering: the reported taskbar state, the last used workspace, shortcut saves reaching an open page, every shortcut having an editor, the notice's place, size, kinds and close button, and an unowned strip coming back over its window after activation, a raise and a tab click.