Repository navigation
chore: keep leafs/http, anchor and exception below v5 on v4.x - #337
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #335 / #336, approved by Michael on 17 Oct.
composer.jsononv4.xrequiredleafs/http,leafs/anchorandleafs/exceptionas"*", so a fresh install (and CI'scomposer update) now pulls the v5 packages.leafs/exception5.x no longer shipsLeaf\Exception\Run, so the suite fails with "class not found" before any test runs.This constrains all three to
<5.0. Nothing else changes.Resolved locally with
composer update -W:Full suite: 11 passed (incl. the #327 regression tests).
Second commit (CI only): on PHP 8.4+ CI's
composer updatepickssymfony/console8.x, which removedApplication::add(). The branch's alchemy (bin/alchemyline 22) still calls it, socomposer run testdies with "Call to undefined method ...Application::add()" before any test runs.require-devnow has"symfony/console": "<8.0"(resolves to 7.4 on 8.4). Dev-only; no effect on anyone installing leafs/leaf. (The commit message says "alchemy 4"; on v3.x it's alchemy 2, same cause.)