Repository navigation
contest: remote: retry on connect errors - #122
Merged
Merged
Conversation
Recently, after a reboot, most vmksft services failed to start because they failed to resolve the hostname. Allow them to retry with an exponential backoff, similar to what is done with Patchwork. While at it, switch to 'urllib3' instead of 'requests', and use a 'PoolManager', as recommended on urllib3 doc, to handle both the timeout and the retries settings. We just need to change the response to get 'data' instead of 'content'. Also catch HTTP errors and issues to decode the JSON files. Signed-off-by: Matthieu Baerts <matttbe@kernel.org>
Similar to the parent commit, retry with an exponential backoff in case of connection issues. Also switch to 'urllib3' instead of 'requests' if it is to use Retry from there, and catch errors instead of crashing: that's OK if we don't have the filters there. Signed-off-by: Matthieu Baerts <matttbe@kernel.org>
Member
Author
|
No need to review I suppose: a small fix that can be deployed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Recently, after a reboot, most vmksft services failed to start because they failed to resolve the hostname.
Allow them to retry with an exponential backoff, similar to what is done with Patchwork.
Also switch to 'urllib3' instead of 'requests' if it is to use Retry from there.