Repository navigation
Contest: hw split: post cleaning - #123
Merged
Merged
Conversation
Faker was used as a convenient place to do that, but at the end, this is not needed. Indeed, the UI can load separated JSON files -- safer in a way not to depend on multiple services to get the final file -- and two pw_contest services are now being used, using each info individually. So let's drop that. Signed-off-by: Matthieu Baerts <matttbe@kernel.org>
Now that we have two 'faker' services, each of them loads a single branches.json file, no need to handle more than one. By doing that, we can fallback to the right 'branches.json' file in the URL (even if it shouldn't be use as github.com is currently always used). Signed-off-by: Matthieu Baerts <matttbe@kernel.org>
Member
Author
|
No need to review this, mostly removed features that are no longer used. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Here are just some small changes post "HW split": the faker service no longer handle multiple inputs: 'infos' are no longer combined, and only one "branches" file is used. Let's simplify this, and suggest a more correct 'fallback'.