Repository navigation
Fix artifacts in RTP multicast streams - #440
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
RTP multicast IPTV streams (
rtp://239.x.x.x:port, MPEG-TS over RTP, as used by e.g. Swisscom) play with constant blocky artifacts and smearing in Hypnotix. The same streams play cleanly in VLC.The packets arrive intact: the kernel UDP counters (
UdpRcvbufErrors,UdpInErrors) stay at 0. The damage happens in mpv's default handling ofrtp://. Over 60 seconds of the same channel, mpv's log showed:Packet corrupt/PES packet size mismatchmpv rtp://…(current behaviour)mpv --demuxer-lavf-format=rtp rtp://…With libavformat's
rtpdemuxer forced, the only remaining decoder messages are the expected ones from joining a stream mid-GOP (missing PPS until the first keyframe).This change passes
demuxer-lavf-format=rtpas a per-fileloadfileoption forrtp://URLs only. Other URLs, and the user's global MPV options, are unaffected.