Repository navigation
Conversation
fridrich
force-pushed
the
fix-osd-stop
branch
from
October 22, 2026 13:24
960f482 to
5d8b0c9
Compare
Contributor
Author
|
@mtwebster this could be interesting? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When playback is stopped from mpv itself (the on-screen controller's stop, a keyboard shortcut, or the stream ending), Hypnotix doesn't notice. The player area stays black, the channel name and URL remain, and
active_channelis still set.Hypnotix only observes
core-idle, which it uses for the screensaver inhibit.core-idleis also true while paused, so it can't tell a stop from a pause.This change:
idle-activeproperty, which is only true when no file is loaded, and callson_stop_button()when it becomes trueis_changing_channelflag aroundplay_async(), because mpv is briefly idle betweenstop()and loading the next channel, and that must not count as a stopidle_activein the handler, because the handler runs later on the GTK main loop and a new channel may have started by thenon_stop_button()clear the channel name/URL and show the empty page, instead of leaving the black player areaTested: stopping from the OSD while playing and while paused returns to the empty page.