Repository navigation
P0: verify ARStack M3.H SV decoding with VLAN 0, long BER and 4I+4V - #55
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 8a2ab90186
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| var apdu = GoldenFrames.Tlv(0x60, | ||
| GoldenFrames.Tlv(0x80, new byte[] { 0x01 }), | ||
| GoldenFrames.Tlv(0xA2, asdu)); |
There was a problem hiding this comment.
Both theory cases generate only short-form BER lengths: the ASDU, ASDU sequence, and outer APDU have value lengths of 99, 101, and 106 bytes, respectively, and GoldenFrames.Tlv emits long-form lengths only at 128 bytes or above. Consequently, this regression passes even if the decoder rejects every long-form length, leaving the long-BER interoperability case advertised by this commit untested. Explicitly encode long-form lengths in the reference fixture and assert their presence before decoding.
Useful? React with 👍 / 👎.
Cross-project regression for the reported issue that ARStack M3.H SV was not visible in DigSubAnalyzer and ARSAS. Tests priority-tagged VLAN ID 0 / PCP4 and untagged M3.H-shaped 4I+4V packets through the actual process-bus decoder and analyzer stream discovery. Expected APPID 0x4000, 64-byte data, smpCnt 3999, svID MU01_SV1, smpSynch 2, optional gmIdentity. Fixture is source-derived and synthetic, not a captured frame from the user's NIC. A successful decoder test does not close the reported physical RX incident; a real PCAP and capture-path check are still required.