Repository navigation
Conversation
…gates (M2I) Reuse canonical typed decoder and DataSets user selection, capture quality/timestamp in both native Browser panes, fail closed for malformed quality and stale DataSet selection. Synthetic samples exist only in the CLI QA harness; no protocol/engine changes, polling or duplicate model.
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: e166d72aba
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
…iewport Put typed Quality/TimeQuality before generic DA metadata and assert actual viewport intersection of typed rows in rendered screenshots. Preserve virtualized tree, lazy DataSets and canonical decoder.
… canonical selection Separate canonical SCL completion from native pane instantiation; allow up to 40 QA-only event-loop checks and report exact setup stage on failure. Do not introduce polling into production UI.
…ics for M2I On deterministic QA setup failure only, report the selected DataSet's IEC members, indexed canonical node lookup, and authoritative MMS member identities. Keep QA fail-closed; do not guess or rewrite protocol references.
…s (M2I) SCL source references use IED/LD/LN.DO.DA [FC], while the indexed canonical MMS model uses IEDLD/LN.DO.DA and an independent FC. Normalize from parsed typed SCL fields once, preserve member order and the original SCL document for provenance, avoid duplicated FC in DataSets, and add deterministic direct q/t lookup regression.
Historical PR reconciliation / archival — 2026-10-24Disposition: CLOSE AS SUPERSEDED OLD SOURCE, NOT MERGED, AND NOT A FEATURE ACCEPTANCE PASS. Verified historical head: The distinct acceptance remains: selected Quality/TimeQuality visual QA screenshots and negative cases. Canonical engineering owner: #128; migration index #308. All commits and review notes remain reachable from this closed PR. A new narrowly scoped PR must branch from current main, first identify genuinely missing behavior and then pass targeted Qt/MMS/schema/GUI tests. Do not bulk-merge the historical branch, silently lose unknown MMS type safety, or claim physical IED acceptance from old CI. No M3.H Stable asset is modified by this closure. |
Baseline
9a780133157db207314ce5256bde446de761b778.Implementation
--qa-browser-evidence-output DIRonly for CI/QA, requiring a real opened SCL fixture. It resolves q/t DA directly from the authoritative DataSet and canonical MMS item index (no shadow semantic model, parser, or new polling).decodeEngineeringEvidenceand inject samples only intoMmsLiveTreeModelin this explicitly flagged synthetic QA mode.data-model-quality.png,data-model-timestamp.png,datasets-quality.png,datasets-timestamp.png.Acceptance
No firmware, PTP/SMV, Studio release/installer, legacy web app, protocol parsing or q/t semantic changes.