Repository navigation
Studio P0: preserve SV/PTP milestone; exact 4I+4V START snapshot and polished operator layout #240
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
8d577ba
d611ce1
886363a
cce5d83
e52cdf8
c203f92
fe7ad13
9a3ea46
a5c0f86
ed1cc2f
d2eb3e3
63b0c20
6840959
e18dea3
c86bb64
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -281,9 +281,11 @@ SurfacePanel { | |
| controller.showMessage(ribbon.startReason(), false) | ||
| return | ||
| } | ||
| const accepted = controller.pendingApply | ||
| ? smartSession.requestStartWithScenario(controller.startScenarioSnapshot()) | ||
| : smartSession.requestStart() | ||
| // Always bind START to the current table snapshot. A previous live | ||
| // session may have cleared pendingApply, but STOP/START must never | ||
| // recycle stale waveform values from the device. | ||
| const accepted = smartSession.requestStartWithScenario( | ||
| controller.startScenarioSnapshot()) | ||
|
Comment on lines
+287
to
+288
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
The Qt CI job directly runs AGENTS.md reference: AGENTS.md:L249-L257 Useful? React with 👍 / 👎. |
||
| if (!accepted) { | ||
| controller.pendingApply = true | ||
| controller.showMessage("Start rejected. Check device status.", true) | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When a focused neutral button is activated with Space or Enter while the pointer is elsewhere,
downselects the new light#d6e3f1fill buthoveredremains false, so this expression retains the lighttheme.textSoftcaption and makes it nearly unreadable. Treatdownlikehoveredwhen selecting the dark caption color.Useful? React with 👍 / 👎.