Repository navigation
P0 Studio: fix live GUI frequency and channel ENABLE delivery; define on-wire acceptance - #249
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 1f9616873f
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| if (liveNow && matrix.session.requestSetEnabled(signalRow.sid, checked)) | ||
| matrix.controller.pendingApply = false |
There was a problem hiding this comment.
When the bounded worker queue is full, requestSetEnabled() still returns true because DeviceController::sendCommandBatch() reports only whether QMetaObject::invokeMethod() accepted the callback; DeviceIoWorker can reject the command later in enqueueCommandsInternal(). Clearing pendingApply here therefore labels an ENABLE edit as applied even though it never reached the board; the new frequency path has the same issue. Retain the pending state until worker admission or positive device evidence is reported.
AGENTS.md reference: AGENTS.md:L112-L116
Useful? React with 👍 / 👎.
| const liveNow = workflowBar.injectionRunning && | ||
| workflowBar.session && workflowBar.session.liveControlReady && | ||
| !root.pendingApply | ||
| root.markScenarioDirty() | ||
| if (workflowBar.session && workflowBar.session.liveControlReady && !root.pendingApply) | ||
| workflowBar.session.requestSetFrequency(value) | ||
| if (liveNow && workflowBar.session.requestSetFrequency(value)) |
There was a problem hiding this comment.
During a running injection, onTextEdited fires for every valid intermediate value, so replacing 50 by typing 60 can queue FREQ 6 before FREQ 60. The worker does not coalesce these commands, meaning the board can briefly generate the unintended intermediate frequency and the rapid events can also consume queue capacity. Send only the committed value from editingFinished, or debounce and coalesce the edits as the signal fields do.
AGENTS.md reference: AGENTS.md:L126-L126
Useful? React with 👍 / 👎.
Stage-main housekeeping · 2026-10-23 · SUPERSEDED, NOT MERGEDOriginal source SHA: Code/regression replacement evidence: Former live checkbox ENABLE and per-keystroke frequency command gating are replaced by checkbox-free always-enabled 4I4V GUI, commit-on-Enter/focus-out frequency input and coalesced automatic eight-channel atomic CFG commit with board ACK/readback. Current operator contract tests guard the new workflow; original stepwise SET path is intentionally obsolete. Exact-head software check: Native Preview 39882032904 SUCCESS (ESP32 firmware + native Windows preview/session harness). The larger Draft-routed CI matrix was SKIPPED; success is not physical STOP safety, real 4I4V waveform parity or SIPROTEC acceptance. Open acceptance ownership: #286 release gate; #42 physical live-setpoint operation, no START/STOP/PTP reset and no smpCnt gaps; #154 selected IED PTP lock/smpSynch/4I4V relay evidence, sustained SOAK and STOP/START. The separate #253 LIVE CFG candidate remains OPEN pending exact hardware behavior; #284 external-GM actuator remains OPEN. No source branch removed, no PR merged, no firmware or UI code changed, no This source PR no longer needs a competing review/merge route because new production code owns its implemented functionality. Historical source/candidate remains recoverable in this PR. |
Field end-to-end audit identified two confirmed GUI-to-board live-update bugs: both checkbox ENABLE and frequency text edit set pendingApply=true before checking !pendingApply, so edits could be shown in GUI but suppressed on the wire. This PR captures prior live eligibility, enqueues updates on RUNNING only, and retains pending draft when queueing fails. Adds operator structural regression and
docs/STUDIO_BOARD_WIRE_RELIABILITY_AUDIT_2026-10-19.mddocumenting verified code paths, remaining atomicity/readback risks, physical 4I+4V/PCAP fidelity acceptance, 4000fps continuity and <=10s genuine PTP AUTO lock. No firmware changes and no forced smpSynch. Await exact-head CI, then field captures; do not merge/claim physical qualification yet.