Repository navigation
fix(glfw): complete Windows link dependencies and add native smoke test - #538
Merged
Merged
Conversation
Sunrisepeak
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Direct use of
compat.glfwon Windows fails to link: GLFW's own Win32 sources reference User32 window/input APIs and Shell32 drag/drop APIs, but the package declared only GDI32. The initial Windows CI run reproduced unresolvedLoadCursorW,CreateWindowExW,RegisterClassExW, andDragAcceptFilesin GLFW objects (failure log).Add
user32andshell32towindows.runtime.libraries, retaining dialect-neutral linking. These calls belong to GLFW; CMake's Windows defaults previously concealed the missing declarations. Do not add import libraries for APIs GLFW dynamically loads or for application OpenGL/Vulkan calls. Keep existing package versions and the upstream GLFW 3.4 archive/hash/mirrors. Source is unchanged; xpkg refreshes the descriptor without a version bump. The new example consumes3.4.Add standalone
tests/examples/glfw, consuming only GLFW from this checkout. It asserts Null-platform window behavior on all platforms; on Windows it additionally requires the native Win32 backend and creates/checks/destroys a hidden window. It usesGLFW_NO_APIand no application graphics API calls, and fails on initialization errors.Validation: local
mcpp test -p glfwwith CI-pinned mcpp 2026.10.1.2 passed (1 passed, 0 failed). All applicable latest PR CI checks passed: Windows native build/link/window execution usingcompat.glfw 3.4, Linux default and LLVM, macOS, lint, CN mirror reachability, graphics install side effects, and site build.The smoke window uses 640×480 to accommodate the native Windows minimum window size. Initialization and native-window assertions remain mandatory.