Skip to content

fix: support reinitializing OpenApiOperation.Tags to null and custom comparers (#3116) - #3142

Merged
Vincent Biret (baywet) merged 1 commit into
support/v2from
fix/additional-tags-to-v2
Oct 21, 2026
Merged

Vincent Biret (baywet) merged 1 commit into
support/v2from
fix/additional-tags-to-v2

Conversation

@baywet

Copy link
Copy Markdown
Member

port of #3116

…comparers (#3116)

* fix: preserve custom tag comparers and sorted sets in OpenApiOperation copy constructor

Align the OpenApiOperation copy constructor with OpenApiOperation.Tags setter to preserve custom equality comparers, sorted sets, and immutable sorted sets, and add corresponding copy constructor unit tests.

* refactor: deduplicate tag normalization logic into static helper

Extract CopyTags static method to deduplicate tag normalization logic between OpenApiOperation.Tags setter and the copy constructor as requested in review.
@baywet
Vincent Biret (baywet) requested a review from a team as a code owner October 21, 2026 17:48
@baywet
Vincent Biret (baywet) enabled auto-merge (squash) October 21, 2026 17:48
@github-code-quality

Copy link
Copy Markdown

Code coverage overview

Languages: C#

C# / code-coverage/dotnet

support/v2 4f53ad5 fix/additional-tags-... f417cee +/-
93% 24% -69%
View coverage of the 10 most impacted files.
File support/v2 4f53ad5 fix/additional-tags-... f417cee +/-
_/src/Moq/Mock`1.cs 0% 26% +26%
_/src/Verify/Se.../ScrubEngine.cs 0% 29% +29%
_/src/Verify/Ve...rifier_Inner.cs 0% 35% +35%
_/src/Verify/Ve...nnerVerifier.cs 0% 46% +46%
_/src/Verify/At...fierSettings.cs 0% 60% +60%
_/src/Verify/Se...fierSettings.cs 0% 62% +62%
_/src/Verify/Se...tionSettings.cs 0% 65% +65%
_/src/Verify/Fi...eNameCleaner.cs 0% 85% +85%
_/src/Verify/Se...eScrubberSet.cs 0% 85% +85%
_/src/EmptyFile...leExtensions.cs 0% 86% +86%

ℹ️ Calculations represent line coverage. Results may change as calculations are updated.

@sonarqubecloud

Copy link
Copy Markdown

Quality Gate Failed Quality Gate failed

Failed conditions
0.0% Coverage on New Code (required ≥ 80%)

See analysis details on SonarQube Cloud

@baywet
Vincent Biret (baywet) merged commit 9cfcdd2 into support/v2 Oct 21, 2026
16 of 17 checks passed
@baywet
Vincent Biret (baywet) deleted the fix/additional-tags-to-v2 branch October 21, 2026 18:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants