Repository navigation
Escape quotes in synthesized module specifiers - #64839
Merged
Ryan Cavanaugh (RyanCavanaugh) merged 1 commit intoOct 15, 2026
Merged
Ryan Cavanaugh (RyanCavanaugh) merged 1 commit into
Ryan Cavanaugh (RyanCavanaugh) merged 1 commit into
Conversation
typescript-automation
Bot
added
For Uncommitted Bug
Jake Bailey (jakebailey)
approved these changes
Oct 15, 2026
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
Static review identified no blocking issues in the localized escaping changes and accompanying regression tests.
0 open findings
What changed in this PR
Fixes quote escaping in synthesized module specifiers so language-server import suggestions remain valid.
Changes:
- Applies snippet escaping only to snippet completions, preserving literal backslashes.
- Escapes module specifiers in JSDoc import types.
- Adds regression tests covering quote preferences, import fixes, and completions.
| File | Description |
|---|---|
tsc/internal/ls/completions.go |
Separates string quoting from snippet escaping. |
tsc/internal/ls/autoimport/fix.go |
Escapes quoted JSDoc import specifiers. |
tsc/internal/fourslash/tests/autoImportQuotedModuleSpecifier_test.go |
Tests quoted specifiers across import workflows. |
🧠 Review effort: Balanced
💡 Add a code-review agent skill for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes cases where package.json could have a module specifier that closed the import name, making the importing file syntactically invalid or unexpected:
I am not attached to this generated testcase, it's not great, but does do the job. Open to changing it to a matrix of single cases if anyone cares.