Repository navigation
Python: Tool name whitespace bugfix - #9557
Jose Alvarez (jpalvarezl) merged 1 commit into
Conversation
There was a problem hiding this comment.
🟢 Approval recommended
The focused fix preserves tool identity, includes regression coverage, and has no identified blocking issues.
No open issues 🎉
What changed in this PR
Preserves exact tool names in Python approval rules, preventing whitespace-distinct names from being conflated.
Changes:
- Retains tool-name whitespace while still rejecting blank names.
- Adds regression coverage for construction and serialization round trips.
| File | Description |
|---|---|
| python/packages/core/tests/core/test_harness_tool_approval.py | Tests whitespace preservation and serialization. |
| python/packages/core/agent_framework/_harness/_tool_approval.py | Stores the original tool name without trimming. |
Review effort: Balanced
There was a problem hiding this comment.
MAF Automated Review — Iteration 1
Result: No findings
Scope: full PR (1 commit(s)): 4aa6c1402a0d
Model: gpt-5.6-sol
Overview
The change preserves the exact approved tool identity while retaining rejection of empty and whitespace-only rule names. Exact name matching, trusted pending-request rebinding, hosted-server and argument boundaries, and the new serialization round-trip test constrain the changed behavior. No publishable Critical, High, or Medium concern was established.
Reviewed the supplied pull-request change set across correctness, security/reliability, architecture, and failure behavior.
No publishable findings remained after source verification for this scope.
Motivation & Context
Description & Review Guide
Related Issue
Fixes #
AI Assistance
AI assistance details:
Contribution Checklist
breaking changelabel (or add "[BREAKING]" to the title prefix, before or after any language prefix) — a workflow keeps the label and title prefix in sync automatically.