Repository navigation
chore: check sent messages against the protocol spec in tests - #3258
Merged
Pavel Feldman (pavelfeldman) merged 2 commits intoOct 15, 2026
Merged
Conversation
Pavel Feldman (pavelfeldman)
force-pushed
the
protocol-check
branch
from
October 15, 2026 03:44
579e558 to
e315d9f
Compare
Dmitry Gozman (dgozman)
approved these changes
Oct 15, 2026
Yury Semikhatsky (yury-s)
approved these changes
Oct 15, 2026
Pavel Feldman (pavelfeldman)
merged commit Oct 15, 2026
f549909
into
microsoft:main
28 of 29 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
playwright/_impl/_protocol.pyfrompackages/protocol/spec(scripts/codegen/generate_protocol.py, run byupdate_api.sh).PW_CHECK_PROTOCOL=1, which the tests set, check each sent message for unknown commands, unknown or missing parameters, and wrong types. The driver drops unknown parameters silently.Route.fulfillsentcontentType/json,Browser.start_tracingsentpath,Locator.clearandMouse.dblclicksenttitle,wait_for_functionsentpolling, and the metadata hadapiName/wallTime._helper.pyto_url_match.py(was_glob.py).