Repository navigation
chore: fix the review findings on the typed channels - #3268
Merged
Pavel Feldman (pavelfeldman) merged 1 commit intoOct 16, 2026
Merged
Pavel Feldman (pavelfeldman) merged 1 commit into
Pavel Feldman (pavelfeldman) merged 1 commit into
Conversation
- Channel allows a handler to be registered more than once; each off<Event> call removes one registration. - Move the Channel base class to _channel.py so that _connection.py imports the generated channel classes at module level. - Route.fulfill raises on a body that is neither str nor bytes. - convert_input_files reads the file mtimes inside the internal createTempFiles call, as upstream does. - CDPSession "event" payload has no None placeholder for params.
Pavel Feldman (pavelfeldman)
force-pushed
the
protocol-channel-fixes
branch
from
October 16, 2026 16:59
14f53a2 to
db6d912
Compare
Yury Semikhatsky (yury-s)
approved these changes
Oct 16, 2026
Pavel Feldman (pavelfeldman)
merged commit Oct 16, 2026
3e7abc4
into
microsoft:main
29 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Channelallows a handler to be registered more than once; eachoff<Event>removes one registrationChannelbase class moves to_channel.py, so_connection.pyimports the generated channel classes at module levelRoute.fulfillraises on a body that is neitherstrnorbytesconvert_input_filesreads the file mtimes inside the internalcreateTempFilescall, as upstream doesCDPSession"event" payload has noNoneplaceholder forparamsStacked on #3264.