Repository navigation
test: port the upstream tests by registry id - #3269
Open
Pavel Feldman (pavelfeldman) wants to merge 1 commit into
Open
Pavel Feldman (pavelfeldman) wants to merge 1 commit into
Pavel Feldman (pavelfeldman) wants to merge 1 commit into
Conversation
Port every test in upstream's tests/registry.md to tests/async and
tests/sync, named after its id and title, or list it in
tests/upstream_not_ported.txt with the reason.
scripts/check_test_registry.py checks this in CI. The older tests move
to tests/{async,sync}/legacy.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
tests/registry.mdtotests/asyncandtests/sync, namedtest_<ID>_<title>, or list it intests/upstream_not_ported.txtwith the reason (3699 ported, 1234 not ported).scripts/check_test_registry.pychecks the coverage; CI runs it in the lint job.tests/assetswith upstream; extend the test server, fixtures and helpers that the ported tests need.reason="python: ...").tests/{async,sync}/legacy.