Repository navigation
Download Electron's types for the vscode scenario - #161
Merged
Merged
Conversation
VS Code dropped its electron dependency (VS Code PR 331833) and now downloads electron.d.ts in a postinstall script, which npm ci --ignore-scripts skips. Without those types, the scenario reports almost 400 errors and checks every Electron-facing file against missing declarations, so it measures a different and less realistic workload than before. The file is fetched on the host because the sandbox proxy does not allow GitHub's release asset hosts, and it is verified against VS Code's checksum manifest without running any VS Code code.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
VS Code dropped its electron dependency (microsoft/vscode#331833) and now downloads electron.d.ts in a postinstall script, which npm ci --ignore-scripts skips. Without those types, the scenario reports almost 400 errors and checks every Electron-facing file against missing declarations, so it measures a different and less realistic workload than before.
The file is fetched on the host because the sandbox proxy does not allow GitHub's release asset hosts, and it is verified against VS Code's checksum manifest without running any VS Code code.