Skip to content

PYTHON-5942 Remove redundant local SRV hostname validation tests #3133

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
aclark4life merged 1 commit into from
Oct 19, 2026
Merged

PYTHON-5942 Remove redundant local SRV hostname validation tests #3133

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 0 additions & 11 deletions test/asynchronous/test_dns.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -416,17 +416,6 @@ async def test_15_accept_an_underscore_in_srv_allowed_hosts_suffix(self):
)
self.assertEqual(["cluster.my_domain.net"], [node[0] for node in res["nodelist"]])

async def test_srv_hostname_with_three_or_more_parts_may_equal_the_returned_hostname(
self,
):
test_cases = [
{
"query": "_mongodb._tcp.blogs.mongodb.com",
"mock_target": "blogs.mongodb.com",
},
]
await self.run_initial_dns_seedlist_discovery_prose_tests(test_cases)


class TestPublicSuffixListParsing(unittest.TestCase):
def test_1_multi_label_ordinary_rule(self):
Expand Down
8 changes: 8 additions & 0 deletions test/srv_seedlist/replica-set/identical-hostnames-valid-four-parts.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
{
"uri": "mongodb+srv://test.build.10gen.cc/",
"seeds": [
"test.build.10gen.cc:27017"
],
"ping": false,
"comment": "Should not throw when SRV hostname and resolved hostname are identical and SRV hostname has four dot-separated parts."
}
8 changes: 8 additions & 0 deletions test/srv_seedlist/replica-set/identical-hostnames-valid-three-parts.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
{
"uri": "mongodb+srv://build.10gen.cc/",
"seeds": [
"build.10gen.cc:27017"
],
"ping": false,
"comment": "Should not throw when SRV hostname and resolved hostname are identical and SRV hostname has three dot-separated parts."
}
11 changes: 0 additions & 11 deletions test/test_dns.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -412,17 +412,6 @@ def test_15_accept_an_underscore_in_srv_allowed_hosts_suffix(self):
)
self.assertEqual(["cluster.my_domain.net"], [node[0] for node in res["nodelist"]])

def test_srv_hostname_with_three_or_more_parts_may_equal_the_returned_hostname(
self,
):
test_cases = [
{
"query": "_mongodb._tcp.blogs.mongodb.com",
"mock_target": "blogs.mongodb.com",
},
]
self.run_initial_dns_seedlist_discovery_prose_tests(test_cases)


class TestPublicSuffixListParsing(unittest.TestCase):
def test_1_multi_label_ordinary_rule(self):
Expand Down
Loading