Repository navigation
Rogue SPR: prototype Pol & Escapa (Fitch) leaf selector (#174) - #226
Open
ms609-agent wants to merge 3 commits into
Open
ms609-agent wants to merge 3 commits into
ms609-agent wants to merge 3 commits into
Conversation
Research only; no package code changes. Scores each leaf by the Fitch length it adds when each tree's splits are treated as binary characters on the other tree, with MCI breaking ties. Compared with the current bounded-MCI selector against exact uSPR (528 pairs, <= 32 leaves) and best-known estimates (50-150 leaves); findings in dev/rogue_polescapa_findings.md. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…pper bound Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #226 +/- ##
==========================================
- Coverage 97.74% 97.74% -0.01%
==========================================
Files 60 60
Lines 6577 6575 -2
==========================================
- Hits 6429 6427 -2
Misses 148 148 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Research prototype for #174, with no package code changes. It asks whether a Pol & Escapa (2009)-style leaf-instability score can choose which leaf
SPRDist(method = "Rogue")drops, in place of the per-candidate bounded-MCI scoring.Write-up:
dev/rogue_polescapa_findings.md. Scripts, reference set and results:dev/rogue_polescapa/.Method. Each split of one tree is treated as a binary character and scored with Fitch on the other tree, in both directions. A leaf's score is the number of steps saved when that leaf is coded
?in every character. One downpass and one uppass give every leaf's score. A bit-parallel C++ kernel is included (fitch_bitpar.cpp).Recommendation. Adopt it as the selector, with MCI used only to break ties among the leaves with the top Fitch score (
both-tied).both-tiedis equal or better than the current selector everywhere except random pairs of 8–14 leaves: there it over-estimates by one move on 21 of 120 pairs, against 9 for the current selector.spr_rogue_scores(). A harness that uses pure Fitch runs about 2×, 10× and 40× faster thanSPRDistat 30, 80 and 150 leaves. The cost ofboth-tiedis projected rather than measured: it would score 2–3 tied candidates in 30–46% of iterations.both-tiedand costs more.A C++ implementation is being worked on separately and depends on the
src/spr.cppincremental-fill work landing first.🤖 Generated with Claude Code