Skip to content

fix: Avoid logging for some "paths" - #121

Closed
AdamMagued wants to merge 1 commit into
msoap:masterfrom
AdamMagued:fix/issue-118
Closed

AdamMagued wants to merge 1 commit into
msoap:masterfrom
AdamMagued:fix/issue-118

Conversation

@AdamMagued

Copy link
Copy Markdown

Resolves #118

Summary

This PR addresses issue #118 by implementing the required fix and adding comprehensive unit test proof.

  • Tested in isolated container sandbox.
  • Verified test suite passes without regressions.

Signed-off-by: Adam Magued <adamismailmageud@gmail.com>
@msoap

msoap commented Oct 17, 2026

Copy link
Copy Markdown
Owner

Thank you, @AdamMagued, for taking the time to implement this and add tests.

I understand the usefulness of suppressing frequent health-check requests, and I appreciate the Docker-related concerns raised in #118. Keeping shell2http small and simple is a core project goal, though. A dedicated per-path logging option, with its configuration and path-matching behavior, adds more ongoing complexity than I believe this relatively uncommon need warrants. I prefer to leave this filtering to the surrounding logging setup.

I've decided to keep this functionality outside the scope of shell2http, so I'm declining the feature and closing this PR. Thank you again for your time and contribution, and for understanding the decision.

@msoap msoap closed this Oct 17, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Avoid logging for some "paths"

2 participants