Repository navigation
Preserve binary SOAP attachment content - #1503
Open
KennyMcSimpson wants to merge 1 commit into
Open
KennyMcSimpson wants to merge 1 commit into
KennyMcSimpson wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Binary SOAP attachments lose leading and trailing CR/LF bytes because
Attachment.contentstrips them afterMultipartDecoderhas already removed the MIME boundary framing. This can corrupt downloaded files and invalidate signatures, as reported in #1249 and #1481.Return binary content unchanged, retaining the existing base64 decoding behavior. Add seven tests built from actual multipart bytes, covering leading/trailing CRLF, an all-CRLF payload, non-text bytes, ordinary content, and empty content. Update three existing fixture expectations to retain the extra CRLF that belongs to their payload; the fixture without that extra CRLF keeps its original expectation.
Validation:
email.BytesParserpreserves the same bytes for all seven multipart cases. RFC 2046 section 5.1.1 confirms that when two CRLF sequences precede a boundary, the first belongs to the body.Fixes #1249.
Fixes #1481.
AI assistance: prepared and validated with OpenAI Codex. These are local checks; no human review or successful upstream CI is claimed.