Skip to content

NI-DCPower: Add example for sinking DC voltage with output resistance on electronic load - #2232

Open
TheodoreEmr wants to merge 2 commits into
ni:masterfrom
TheodoreEmr:nidcpower-sink-dc-voltage-example
Open

TheodoreEmr wants to merge 2 commits into
ni:masterfrom
TheodoreEmr:nidcpower-sink-dc-voltage-example

Conversation

@TheodoreEmr

Copy link
Copy Markdown
  • This contribution adheres to CONTRIBUTING.md.
  • I've updated CHANGELOG.md if applicable.
  • I've added tests applicable for this pull request

What does this Pull Request accomplish?

  • Add nidcpower_sink_dc_voltage_with_output_resistance.py
  • Update docs/nidcpower/examples.rst
  • Update CHANGELOG.md to call out the new examples

What testing has been done?

  • Unit tests added as part of the example file passed.
  • Both tox and tox -c .\generated\nidcpower\tox-system_tests.ini succeeded

@codecov-commenter

codecov-commenter commented Oct 22, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 88.12%. Comparing base (7cf483d) to head (46342f8).
⚠️ Report is 2 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2232   +/-   ##
=======================================
  Coverage   88.12%   88.12%           
=======================================
  Files          88       88           
  Lines       22832    22832           
=======================================
+ Hits        20120    20121    +1     
+ Misses       2712     2711    -1     
Flag Coverage Δ
codegenunittests 84.78% <ø> (ø)
nidcpowersystemtests 94.40% <ø> (+0.04%) ⬆️
nidcpowerunittests 89.53% <ø> (ø)
nidigitalsystemtests 92.04% <ø> (ø)
nidigitalunittests 68.43% <ø> (ø)
nidmmsystemtests 92.33% <ø> (ø)
nifakeunittests 86.08% <ø> (ø)
nifgensystemtests 94.34% <ø> (ø)
nimodinstsystemtests 73.85% <ø> (ø)
nimodinstunittests 94.20% <ø> (ø)
nirfsasystemtests 82.71% <ø> (ø)
nirfsaunittests 63.40% <ø> (ø)
nirfsgsystemtests 81.22% <ø> (ø)
niscopesystemtests 89.99% <ø> (ø)
niscopeunittests 43.20% <ø> (ø)
nisesystemtests 91.50% <ø> (ø)
niswitchsystemtests 81.66% <ø> (ø)
nitclksystemtests 94.87% <ø> (ø)
nitclkunittests 98.26% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ni-jfitzger

Copy link
Copy Markdown
Collaborator

You should pull main so that the system tests can succeed.

@ni-jfitzger

Copy link
Copy Markdown
Collaborator

This seems complicated.
Maybe we should include a link to https://www.ni.com/docs/en-US/bundle/ni-dcpower/page/sinking-dcvoltage-with-output-resistance.html?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants