Repository navigation
Replace GNU Make Codegen with Python - #2241
Open
ni-jfitzger wants to merge 9 commits into
Open
ni-jfitzger wants to merge 9 commits into
ni-jfitzger wants to merge 9 commits into
Conversation
…nto replace-gnu-make-with-python
…doing codegen" Turns out the templates do tweak some metadata, even though we can't see a difference in the output. This reverts commit 8fad161.
Codecov Report❌ Patch coverage is
❌ Your patch status has failed because the patch coverage (58.09%) is below the target coverage (70.00%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## master #2241 +/- ##
==========================================
- Coverage 88.12% 83.19% -4.93%
==========================================
Files 88 89 +1
Lines 22830 23071 +241
==========================================
- Hits 20118 19194 -924
- Misses 2712 3877 +1165
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
[ ] I've updated CHANGELOG.md if applicable.What does this Pull Request accomplish?
The GNU Make code used for code generation was a barrier to entry for anyone not familar with GNU Make and, frankly, even for those who are familiar with it. Some of the code was very difficult to read. Variables and recipes were also scattered across the repo, making it more difficult to read.
Using GitHub Copilot, this PR replaces those files and some of their Python code with a consolidated
build/codegen.py, which implements thecodegen,cleanandinstallerssteps.List issues fixed by this Pull Request below, if any.
What testing has been done?
Ran
tox -e clean,tox -e codegen,tox -e installers,tox -e codegen -- -driver nidmm. No difference seen in the generated files.Ran newly generated unit tests. These don't cover all of codegen.py, but it's more than we had for the MAKEFILE code. Our primary method of catching issues remains ensure_codegen_up_to_date.py, diffs and code review of PRs.
I carefully reviewed all of the new code and had GitHub Copilot scrutinize for any issues that I might have missed.