Skip to content

tools: remove node.gyp and node.gypi from v8.nix requisites #66955

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
aduh95 wants to merge 1 commit into
base: main
Choose a base branch
from
+20 −5
Open

tools: remove node.gyp and node.gypi from v8.nix requisites #66955

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 20 additions & 5 deletions tools/nix/v8.nix
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,8 +37,6 @@ let
../../common.gypi
../../configure.py
../../deps/v8
../../node.gyp
../../node.gypi
../../tools/gyp/pylib
../../tools/gyp_node.py
../../tools/v8_gypfiles/features.gypi
Expand Down Expand Up @@ -154,9 +152,26 @@ stdenv.mkDerivation (finalAttrs: {
return []
EOF
'';
# We need to remove the node_inspector.gypi ref so GYP does not search for it.
# To avoid invalidating cached build on unrelated `node.gyp` and `node.gypi` changes,
# we stub `node.gyp` to only reference the targets needed to build V8.
postPatch = ''
substituteInPlace node.gyp --replace-fail "'includes' : [ 'src/inspector/node_inspector.gypi' ]" "'includes' : []"
cat -> node.gyp <<'EOF'
${builtins.toJSON {
targets = [
{
target_name = "v8_deps_root";
type = "none";
dependencies = lib.unique (
builtins.concatLists (
builtins.filter builtins.isList (
builtins.split "'(tools/v8_gypfiles/v8\\.gyp:[A-Za-z0-9_]+)'" (builtins.readFile ../../node.gypi)
)
)
);
}
];
}}
EOF
''
+ lib.optionalString (icu == null) ''
substituteInPlace configure.py \
Expand All @@ -179,7 +194,7 @@ stdenv.mkDerivation (finalAttrs: {

buildPhase = ''
runHook preBuild
ninja -v -C out/Release v8_snapshot v8_libplatform
ninja -v -C out/Release v8_deps_root
runHook postBuild
'';
installPhase = ''
Expand Down
Loading