Skip to content

[test] deps: update OpenSSL to 4.1.0 - #66960

Closed
nodejs-github-bot wants to merge 2 commits into
openssl-updater-4.1from
actions/openssl-updater-4.1/tools-update-openssl
Closed

nodejs-github-bot wants to merge 2 commits into
openssl-updater-4.1from
actions/openssl-updater-4.1/tools-update-openssl

Conversation

@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

This is an automated update of OpenSSL to 4.1.0 for openssl-updater-4.1.

@nodejs-github-bot nodejs-github-bot added dependencies PRs that add, update, or configure Node.js dependencies. openssl Issues and PRs related to the OpenSSL dependency. labels Oct 23, 2026
@nodejs-github-bot

Copy link
Copy Markdown
Collaborator Author

Review requested:

  • @nodejs/security-wg

@nodejs-github-bot nodejs-github-bot added the needs-ci PRs that need a full CI run. label Oct 23, 2026
@panva panva changed the title [openssl-updater-4.1] deps: update OpenSSL to 4.1.0 [test] deps: update OpenSSL to 4.1.0 Oct 23, 2026
@panva panva added the blocked PRs that are blocked by other issues or PRs. label Oct 23, 2026
@nodejs-github-bot

Copy link
Copy Markdown
Collaborator Author

@panva

panva commented Oct 23, 2026

Copy link
Copy Markdown
Member

one new test failure needs accounting for a changed error code which we'll do in the actual update PR

---
duration_ms: 147.383
exitcode: 1
severity: fail
stack: |-
  node:internal/assert/utils:146
    throw error;
    ^

  AssertionError [ERR_ASSERTION]: Expected values to be strictly equal:
  + actual - expected

  + 'ERR_SSL_BAD_DECRYPT'
  - 'ERR_SSL_DECRYPTION_FAILED_OR_BAD_RECORD_MAC'
             ^

      at TLSSocket.<anonymous> (/home/iojs/build/workspace/node-test-commit-plinux/nodes/rhel10-ppc64le/test/parallel/test-tls-coalesce-records.js:120:16)
      at TLSSocket.<anonymous> (/home/iojs/build/workspace/node-test-commit-plinux/nodes/rhel10-ppc64le/test/common/index.js:512:15)
      at TLSSocket.emit (node:events:514:20)
      at TLSSocket._emitTLSError (node:internal/tls/wrap:1173:10)
      at TLSWrap.onerror (node:internal/tls/wrap:592:11) {
    generatedMessage: true,
    code: 'ERR_ASSERTION',
    actual: 'ERR_SSL_BAD_DECRYPT',
    expected: 'ERR_SSL_DECRYPTION_FAILED_OR_BAD_RECORD_MAC',
    operator: 'strictEqual',
    diff: 'simple'
  }

  Node.js v27.0.0-pre
...

@richardlau

richardlau commented Oct 23, 2026 •

Copy link
Copy Markdown
Member

one new test failure needs accounting for a changed error code which we'll do in the actual update PR

@panva Might be preferable to fix the test separately in a cherry-pickable/backport-able PR. We wouldn't land the OpenSSL 4.1 update PR in Node.js 26, 24, 22 but we might land OpenSSL 4.1 compatibility patches for anyone doing their own builds (e.g. against shared openssl 4.1).

@panva

panva commented Oct 23, 2026

Copy link
Copy Markdown
Member

one new test failure needs accounting for a changed error code which we'll do in the actual update PR

@panva Might be preferable to fix the test separately in a cherry-pickable/backport-able PR. We wouldn't land the OpenSSL 4.1 update PR in Node.js 26, 24, 22 but we might land OpenSSL 4.1 compatibility patches for anyone doing their own builds (e.g. against shared openssl 4.1).

#66962

@panva panva closed this Oct 23, 2026
@panva
panva deleted the actions/openssl-updater-4.1/tools-update-openssl branch October 23, 2026 15:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

blocked PRs that are blocked by other issues or PRs. dependencies PRs that add, update, or configure Node.js dependencies. needs-ci PRs that need a full CI run. openssl Issues and PRs related to the OpenSSL dependency.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants