Repository navigation
fix(logs): pick up the logparser fix for split lines that never end - #408
Merged
Merged
Conversation
Pins logparser 38071d9 (nudgebee/logparser#37). A container that writes a line split across log records and never ends it no longer holds back acknowledgements, so positions for its file keep advancing.
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
mayankpande88
approved these changes
Oct 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pins logparser to
38071d9(nudgebee/logparser#37).Since #407, a file's saved position advances only past delivered lines. A container that writes the first part of a split line and never ends it held back acknowledgements for every later line in that file, so its position stopped advancing. logparser#37 passes such a line on once its first part is ten collector timeouts old.
Verify:
go list -m github.com/nudgebee/logparserprintsv0.0.0-20261023171829-38071d9d9983. logparser'sTestEndlessSplitLineDoesNotBlockAcknowledgementscovers the behaviour.Tested:
go vet ./...,go teston every package CI runs,go test -race ./logs/×3,go build -mod=readonly.