fix: back button moves up a folder instead of closing app by wernrab · Pull Request #226 · opencloud-eu/android

wernrab · 2026-09-10T14:10:17Z

This is similar to oC #4943 but closes the FAB menu on root level as well.

Copilot

🟡 Changes recommended

The current “subfolder” detection uses parentId != ROOT_PARENT_ID, which can disable Back handling in legitimate subfolders (and enable it in unexpected cases), breaking the intended navigation behavior.

Once you've addressed the issues Copilot identified, you can request another Copilot review.

Pull request overview

This PR updates back-button handling in MainFileListFragment so that pressing Back at the root level closes the app (and also collapses the FAB menu when expanded), aligning behavior with the intent described in the PR description and referenced PR.

Changes:

Adds an OnBackPressedCallback to intercept Back presses and collapse the FAB menu when expanded.
Enables/disables the back-press callback based on whether the FAB is expanded or the user is inside a subfolder.
Refreshes the callback enabled-state when the displayed folder changes and when the FAB expand/collapse state changes.

File summaries

File	Description
opencloudApp/src/main/java/eu/opencloud/android/presentation/files/filelist/MainFileListFragment.kt	Adds Back-press callback to collapse the FAB menu first and otherwise browse up, with conditional enablement at root level.

Review details

Suppressed comments (1)

opencloudApp/src/main/java/eu/opencloud/android/presentation/files/filelist/MainFileListFragment.kt:517

isInSubfolder is derived from parentId != ROOT_PARENT_ID, but ROOT_PARENT_ID is also used as the root sentinel in browse-up logic (see manageBrowseUp()), so folders directly under root can have parentId == ROOT_PARENT_ID. In that case this callback will be disabled and Back will fall through to the Activity (exiting) instead of browsing up to root. Also, because parentId is nullable, null != ROOT_PARENT_ID evaluates to true and would incorrectly enable browse-up.

Derive the state from the actual folder being shown (e.g., remotePath != ROOT_PATH) so root is detected reliably.

    private fun updateBackPressedCallbackState() {
        val isInSubfolder = mainFileListViewModel.currentFolderDisplayed.value.parentId != ROOT_PARENT_ID
        onBackPressedCallback.isEnabled = isFabExpanded() || isInSubfolder
    }

Files reviewed: 1/1 changed files
Comments generated: 1
Review effort level: Lite

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Copilot

🟡 Changes recommended

The new back-press enablement logic treats a nullable parentId as “in subfolder,” which can enable the callback in invalid states and lead to a crash path in browse-up handling.

Once you've addressed the issues Copilot identified, you can request another Copilot review.

Review details

Files reviewed: 1/1 changed files
Comments generated: 2
Review effort level: Lite

Copilot

🟡 Changes recommended

The current diff introduces a compilation issue in onViewCreated and the back-press enablement logic can disable navigation in folders whose parent is root.

Once you've addressed the issues Copilot identified, you can request another Copilot review.

Review details

Files reviewed: 1/1 changed files
Comments generated: 1
Review effort level: Lite

Copilot

🟡 Changes recommended

The new fragment-level back callback is likely ineffective because host activities override onBackPressed() and don’t delegate to the OnBackPressedDispatcher in the relevant paths.

Once you've addressed the issues Copilot identified, you can request another Copilot review.

Review details

Files reviewed: 1/1 changed files
Comments generated: 1
Review effort level: Lite

bilogic · 2026-10-03T00:36:40Z

can we merge this please?

Copilot

🟡 Changes recommended

One or more issues must be addressed before approval.

3 open findings

Back callback navigates hidden list instead of closing second fragment · New
Hidden FAB state consumes back press at root · New
updateBackPressedCallbackState() treats parentId == ROOT_PARENT_ID as “not in subfolder”, but…

1 resolved since last review

This fragment registers an OnBackPressedCallback, but the two known host activities for…

🧠 Review effort: Lite

Give feedback about Copilot approvals in this survey to enter a drawing for a $150 gift card.

Copilot

🔵 Needs a closer look

One or more issues must be addressed before approval.

2 open findings

Back callback navigates hidden list instead of closing second fragment
updateBackPressedCallbackState() treats parentId == ROOT_PARENT_ID as “not in subfolder”, but…

1 resolved since last review

Hidden FAB state consumes back press at root

🧠 Review effort: Lite

Give feedback about Copilot approvals in this survey to enter a drawing for a $150 gift card.

Copilot

🔵 Needs a closer look

The back callback can bypass preview cleanup and drawer priority, become stale when the FAB is hidden, and leave an incorrect accessibility description.

2 open findings

Back callback navigates hidden list instead of closing second fragment
updateBackPressedCallbackState() treats parentId == ROOT_PARENT_ID as “not in subfolder”, but…

🧠 Review effort: Lite

Copilot

🟡 Changes recommended

Replacing the file-list fragment removes the Back callback without restoring it for the replacement.

1 open finding

Re-register back callback when switching Spaces or Shares · New

🧠 Review effort: Balanced

Copilot

🟡 Changes recommended

The new menu-collapse paths leave screen readers announcing an incorrect expanded state.

1 open finding

Update expand button content description when collapsing FAB · New

1 resolved since last review

Re-register back callback when switching Spaces or Shares

🧠 Review effort: Balanced

Copilot

🟢 Approval recommended

The focused callback and menu-state changes preserve existing navigation behavior, with no unresolved blocking findings.

No open issues 🎉

1 resolved since last review

Update expand button content description when collapsing FAB

_{Review effort: Balanced}

Copilot

🟢 Approval recommended

The focused changes preserve existing navigation behavior, with no confirmed blocking issues identified.

No open issues 🎉

_{Review effort: Balanced}

                fileIcon.setImageResource(MimetypeIconUtil.getFileTypeIconId(file.mimeType, file.fileName))

-                if (file.isImage) {
+                if (file.hasPreview || file.isImage) {


wernrab · 2026-10-20T12:29:23Z

Beginning with API 33, the activities' onBackPressed() functions might no longer be called directly. A migration to OnBackPressedDispatcher was requested instead. FileDisplayActivity and FolderPickerActivity are fixed with this PR. Other (less important) activities are left unchanged so far.

A more detailed explanation by Copilot:

Activity.onBackPressed() is deprecated since API 33. How reliably it runs depends on the Android version and your targetSdk:

Android 12 and below (API ≤ 32): it is called for the back button, back gesture and nav-bar back, and works reliably.
Android 13+ (API 33+): it is only called if the app hasn't opted into predictive back. That means android:enableOnBackInvokedCallback is false or unset in the manifest. If it is set, the framework skips onBackPressed() and dispatches to OnBackInvokedCallback or OnBackPressedDispatcher instead.
Android 16 (API 36) with targetSdk 36: predictive back is on by default and onBackPressed() is never called. Apps can opt out only temporarily.
AndroidX ComponentActivity: its onBackPressed() forwards to the OnBackPressedDispatcher. If you override it without calling super, your override runs only when the platform still routes to it, which is the "not directly called on some devices" case in the commit comment.

Copilot

🟢 Approval recommended

The changes reuse the existing navigation hierarchy, with no unresolved blocking issues identified.

1 open issue

Refresh skips saving updated preview availability metadata

_{Review effort: Balanced}

Copilot

🟢 Approval recommended

The focused navigation and FAB changes have no identified blocking defects.

1 open issue

Refresh skips saving updated preview availability metadata

_{Review effort: Balanced}

bilogic · 2026-10-20T16:18:36Z

sorry, i'm subscribed to this waiting for its completion and i keep seeing force-pushes, i mean.. is it going to end soon?

wernrab self-assigned this Sep 10, 2026

wernrab marked this pull request as ready for review September 10, 2026 14:23

Copilot AI lite review requested due to automatic review settings September 10, 2026 14:23

Copilot started reviewing on behalf of wernrab September 10, 2026 14:23

View session

guruz self-requested a review September 10, 2026 14:25

Copilot AI reviewed Sep 10, 2026

View reviewed changes

Comment thread ...udApp/src/main/java/eu/opencloud/android/presentation/files/filelist/MainFileListFragment.kt

wernrab force-pushed the fix_folder_up branch from 8464ebc to 49dc4b3 Compare September 10, 2026 15:40

wernrab requested a lite review from Copilot September 10, 2026 15:48

Copilot started reviewing on behalf of wernrab September 10, 2026 15:48

View session

Copilot AI reviewed Sep 10, 2026

View reviewed changes

Comment thread ...udApp/src/main/java/eu/opencloud/android/presentation/files/filelist/MainFileListFragment.kt Outdated

Comment thread ...udApp/src/main/java/eu/opencloud/android/presentation/files/filelist/MainFileListFragment.kt Outdated

wernrab force-pushed the fix_folder_up branch from 074d80b to 415e256 Compare September 10, 2026 16:03

wernrab requested a lite review from Copilot September 10, 2026 16:04

Copilot started reviewing on behalf of wernrab September 10, 2026 16:05

View session

wernrab force-pushed the fix_folder_up branch from 415e256 to 2cdffb9 Compare September 10, 2026 16:08

Copilot AI reviewed Sep 10, 2026

View reviewed changes

Comment thread ...udApp/src/main/java/eu/opencloud/android/presentation/files/filelist/MainFileListFragment.kt Outdated

wernrab requested a lite review from Copilot September 10, 2026 16:08

Copilot started reviewing on behalf of wernrab September 10, 2026 16:09

View session

Copilot AI reviewed Sep 10, 2026

View reviewed changes

Comment thread ...udApp/src/main/java/eu/opencloud/android/presentation/files/filelist/MainFileListFragment.kt Outdated

guruz mentioned this pull request Sep 21, 2026

Back should go to parent folder, not exit app #233

Open

wernrab requested a lite review from Copilot October 8, 2026 13:46

Copilot started reviewing on behalf of wernrab October 8, 2026 13:46

View session

Copilot AI reviewed Oct 8, 2026

View reviewed changes

Comment thread ...udApp/src/main/java/eu/opencloud/android/presentation/files/filelist/MainFileListFragment.kt Outdated

Comment thread ...udApp/src/main/java/eu/opencloud/android/presentation/files/filelist/MainFileListFragment.kt Outdated

wernrab requested a lite review from Copilot October 8, 2026 15:04

Copilot started reviewing on behalf of wernrab October 8, 2026 15:05

View session

Copilot AI reviewed Oct 8, 2026

View reviewed changes

wernrab requested a lite review from Copilot October 9, 2026 10:25

Copilot started reviewing on behalf of wernrab October 9, 2026 10:26

View session

Copilot AI reviewed Oct 9, 2026

View reviewed changes

wernrab requested a lite review from Copilot October 9, 2026 11:52

Copilot AI reviewed Oct 15, 2026

View reviewed changes

Comment thread opencloudApp/src/main/java/eu/opencloud/android/ui/activity/FileDisplayActivity.kt Outdated

wernrab force-pushed the fix_folder_up branch from f100474 to e13f018 Compare October 15, 2026 15:29

wernrab requested a balanced review from Copilot October 15, 2026 15:30

Copilot started reviewing on behalf of wernrab October 15, 2026 15:31

View session

Copilot AI reviewed Oct 15, 2026

View reviewed changes

Comment thread ...udApp/src/main/java/eu/opencloud/android/presentation/files/filelist/MainFileListFragment.kt

wernrab force-pushed the fix_folder_up branch from e13f018 to 32ff982 Compare October 19, 2026 08:41

wernrab requested a balanced review from Copilot October 19, 2026 08:56

Copilot started reviewing on behalf of wernrab October 19, 2026 08:57

View session

Copilot AI reviewed Oct 19, 2026

View reviewed changes

wernrab force-pushed the fix_folder_up branch from 32ff982 to f3b3cd1 Compare October 19, 2026 12:51

wernrab requested a balanced review from Copilot October 19, 2026 12:52

Copilot started reviewing on behalf of wernrab October 19, 2026 12:52

View session

Copilot AI reviewed Oct 19, 2026

View reviewed changes

wernrab force-pushed the fix_folder_up branch from f3b3cd1 to adc6854 Compare October 20, 2026 12:11

wernrab requested a balanced review from Copilot October 20, 2026 12:23

Copilot started reviewing on behalf of wernrab October 20, 2026 12:24

View session

Copilot AI reviewed Oct 20, 2026

View reviewed changes

Comment thread opencloudApp/src/main/java/eu/opencloud/android/presentation/files/filelist/FileListAdapter.kt

fileIcon.setImageResource(MimetypeIconUtil.getFileTypeIconId(file.mimeType, file.fileName))

if (file.isImage) {

if (file.hasPreview || file.isImage) {

wernrab force-pushed the fix_folder_up branch from adc6854 to 5c4407b Compare October 20, 2026 12:32

wernrab requested a balanced review from Copilot October 20, 2026 12:35

Copilot started reviewing on behalf of wernrab October 20, 2026 12:36

View session

Copilot AI reviewed Oct 20, 2026

View reviewed changes

wernrab force-pushed the fix_folder_up branch from 5c4407b to df3e990 Compare October 20, 2026 12:55

wernrab requested a balanced review from Copilot October 20, 2026 12:56

Copilot started reviewing on behalf of wernrab October 20, 2026 12:56

View session

Copilot AI reviewed Oct 20, 2026

View reviewed changes

fix: back button moves up a folder instead of closing app

83cb422

wernrab force-pushed the fix_folder_up branch from df3e990 to 83cb422 Compare October 20, 2026 16:09

wernrab marked this pull request as ready for review October 20, 2026 16:30

Conversation

wernrab commented Sep 10, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

🟡 Changes recommended

Suppressed comments (1)

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

🟡 Changes recommended

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

🟡 Changes recommended

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

🟡 Changes recommended

Uh oh!

Uh oh!

bilogic commented Oct 3, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

🟡 Changes recommended

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

🔵 Needs a closer look

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

🔵 Needs a closer look

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

🟡 Changes recommended

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

🟡 Changes recommended

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

🟢 Approval recommended

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

🟢 Approval recommended

Uh oh!

wernrab commented Oct 20, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

🟢 Approval recommended

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

🟢 Approval recommended

Uh oh!

bilogic commented Oct 20, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

wernrab commented Oct 20, 2026 •

edited

Loading