Skip to content

Temporarily ignore Pillow ImageFile context manager return type #384

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bgilbert merged 1 commit into from
Oct 20, 2026
Merged

Temporarily ignore Pillow ImageFile context manager return type #384

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .pre-commit-config.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ repos:
name: Check Python types
priority: 0
# Pillow is ignored in dependabot.yml
additional_dependencies: [flask, openslide-bin, pillow >= 12.1.0, types-PyYAML, types-setuptools]
additional_dependencies: [flask, openslide-bin, pillow >= 13.0.0, types-PyYAML, types-setuptools]

- repo: https://github.com/rstcheck/rstcheck
rev: v6.3.0
Expand Down
3 changes: 2 additions & 1 deletion openslide/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -392,7 +392,8 @@ def detect_format(cls, filename: lowlevel.Filename) -> str | None:
If the file format is not recognized, return None."""
try:
with Image.open(filename) as img:
return img.format
# mypy will think img is Any until we drop Python 3.10
return img.format # type: ignore[no-any-return]
except OSError:
return None

Expand Down
Loading