Repository navigation
fix(ci): use npm lockfile for stable promotions - #695
Merged
Merged
Conversation
Collaborator
Author
|
Additional root-cause confirmation: reproduced the exact failure from f208917 in a separate temporary checkout with Yarn 1.22.22.
With npm ci against the committed lockfile, both callers resolve TypeScript 5.9.3 and the full build passes under Node 20.20.2. This confirms a dependency-layout/compiler mismatch, not a source-component failure or an npm authentication failure in the original job. |
dlabaj
commented
Oct 16, 2026
dlabaj
left a comment
Collaborator
Author
There was a problem hiding this comment.
Approving and merging. The fact it worked before was because someone checked in yarn.lock file. This repo doesn't use yarn and should use the package.lock file and npm ci instead.
|
🎉 This PR is included in version 6.7.0-prerelease.2 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The v6.7.0 promotion (run 38829219841, job 116743818614) failed while generating the dynamic-module map, with TypeScript parser errors in @types/node/ffi.d.ts. Publishing was skipped.
Promotion currently installs with Yarn despite only package-lock.json being committed, and configures Node after the build. This produces a different dependency layout from the working npm-based build.
Changes
Validation
Publish 6.7.0 after merge
Run:
This executes the corrected workflow from main against the unchanged v6.7.0 source tag. Re-running the original failed run would reuse its old workflow/commit.