ext/intl: Add Transliterator::toRules()

[LamentXU123]

We have Transliterator::createFromRules(). And today I am quite surprised that we can't export a rule added by that in the PHP side. ICU have Transliterator::toRules() but we just forget to export it to PHP.

[devnexen]

what about ?

diff --git a/ext/intl/transliterator/transliterator_methods.cpp b/ext/intl/transliterator/transliterator_methods.cpp
index 8b70219b11c..db92be76824 100644
--- a/ext/intl/transliterator/transliterator_methods.cpp
+++ b/ext/intl/transliterator/transliterator_methods.cpp
@@ -22,6 +22,8 @@
 #endif

 #include <unicode/uenum.h>
+#include <unicode/translit.h>
+#include "../intl_convertcpp.h"

 extern "C" {
 #include "php_intl.h"
@@ -235,26 +237,17 @@ U_CFUNC PHP_FUNCTION( transliterator_to_rules )

        TRANSLITERATOR_METHOD_FETCH_OBJECT;

-       int32_t rules_len = utrans_toRules(to->utrans, escape_unprintable, nullptr, 0,
-               TRANSLITERATOR_ERROR_CODE_P(to));
-       if (TRANSLITERATOR_ERROR_CODE(to) == U_BUFFER_OVERFLOW_ERROR) {
-               TRANSLITERATOR_ERROR_CODE(to) = U_ZERO_ERROR;
-       }
-       INTL_METHOD_CHECK_STATUS(to, "Failed to export transliterator rules");
-
-       int32_t capacity = rules_len < INT32_MAX ? rules_len + 1 : rules_len;
-       UChar *rules = reinterpret_cast<UChar *>(safe_emalloc(capacity, sizeof(UChar), 0));
-       rules_len = utrans_toRules(to->utrans, escape_unprintable, rules, capacity,
-               TRANSLITERATOR_ERROR_CODE_P(to));
-       if (U_FAILURE(TRANSLITERATOR_ERROR_CODE(to))) {
-               efree(rules);
+       UnicodeString rules;
+       reinterpret_cast<const icu::Transliterator *>(to->utrans)->tble);
+
+       zend_string *u8str = intl_charFromString(rules, TRANSLITERAT
+       if (!u8str) {
+               if (U_SUCCESS(TRANSLITERATOR_ERROR_CODE(to))) {
+                       TRANSLITERATOR_ERROR_CODE(to) = U_MEMORY_ALLOCATION_ERROR;
+               }
                INTL_METHOD_CHECK_STATUS(to, "Failed to export transliterator rules");
        }
-       if (TRANSLITERATOR_ERROR_CODE(to) == U_STRING_NOT_TERMINATED_WARNING) {
-               TRANSLITERATOR_ERROR_CODE(to) = U_ZERO_ERROR;
-       }
-
-       INTL_METHOD_RETVAL_UTF8(to, rules, rules_len, 1);
+       RETURN_STR(u8str);
 }
 /* }}} */

[LamentXU123]

Yeah I don't see that API before :)

[LamentXU123]

Thanks!

[ndossche]

Question about this error path:
This runs if u8str is a NULL pointer, yet the execution of this branch doesn't stop after INTL_METHOD_CHECK_STATUS, which means that RETURN_STR(NULL) will be executed.
That's not legal. What am I missing?

[ndossche]

Ah god, it's a macro that returns (conditionally) false... I see

[LamentXU123]

I think its better to set error message explictly and RETURN_FALSE; ... wdyt?
I mean as a refactor to the code base.

[ndossche]

I don't mind per se that the macro returns, but the name should make that clear.