Skip to content

Fix GH-24386: JIT: register operand must be loaded before the typed reference check - #24387

Open
ndossche wants to merge 1 commit into
php:PHP-8.4from
ndossche:fix-24386
Open

ndossche wants to merge 1 commit into
php:PHP-8.4from
ndossche:fix-24386

Conversation

@ndossche

Copy link
Copy Markdown
Member

When the left side of a compound assignment may be a ref, the JIT adds a ref type check. The typed-reference path calls a helper that doesn't load the right hand side of the compound assignment. That's in contrast to the normal path that does put it in a register. If the typed ref path doesn't load, then the value remains undefined.

…d reference check

When the left side of a compound assignment may be a ref, the JIT adds a
ref type check. The typed-reference path calls a helper that doesn't
load the right hand side of the compound assignment.
That's in contrast to the normal path that does put it in a register.
If the typed ref path doesn't load, then the value remains undefined.

@jorgsowa jorgsowa left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

JIT: register operand must be loaded before the typed reference check

2 participants